Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 8587008: MIPS: Fix lazy deoptimization at HInvokeFunction and enable target-recording call-function stub. (Closed)

Created:
9 years, 1 month ago by kisg
Modified:
9 years, 1 month ago
Reviewers:
Paul Lind, fschneider, danno
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix lazy deoptimization at HInvokeFunction and enable target-recording call-function stub. Port r10006 (4b344a03). Original commit message: Changes the way we do lazy deoptimization: 1. For side-effect instructions, we insert the lazy-deopt call at the following LLazyBailout instruction. CALL GAP LAZY-BAILOUT ==> lazy-deopt-call 2. For other instructions (StackCheck) we insert it right after the instruction since the deopt targets an earlier deoptimization environment. STACK-CHECK GAP ==> lazy-deopt-call The pc of the lazy-deopt call that will be patched in is recorded in the deoptimization input data. Each Lithium instruction can have 0..n safepoints. All safepoints get the deoptimization index of the associated LAZY-BAILOUT instruction. On lazy deoptimization we use the return-pc to find the safepoint. The safepoint tells us the deoptimization index, which in turn finds us the PC where to insert the lazy-deopt-call. Additional changes: * RegExpLiteral marked it as having side-effects so that it gets an explicitlazy-bailout instruction (instead of treating it specially like stack-checks) * Enable target recording CallFunctionStub to achieve more inlining on optimized code. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=10020

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -184 lines) Patch
M src/mips/deoptimizer-mips.cc View 2 chunks +22 lines, -48 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 6 chunks +15 lines, -13 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 28 chunks +97 lines, -123 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kisg
9 years, 1 month ago (2011-11-16 22:47:15 UTC) #1
fschneider
9 years, 1 month ago (2011-11-17 14:24:09 UTC) #2
Thanks for the patch.

LGTM. I'll land it.

Powered by Google App Engine
This is Rietveld 408576698