Add PyAuto tests for triggering browser/page action.

chrome/browser/automation/testing_automation_provider.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/automation/testing_automation_provider.h"
 
 #include <map>
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 35 matching lines @@
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/debugger/devtools_window.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/download/save_package_file_picker.h"
 #include "chrome/browser/extensions/extension_browser_event_router.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_tab_util.h"
 #include "chrome/browser/extensions/extension_updater.h"
 #include "chrome/browser/history/top_sites.h"
 #include "chrome/browser/importer/importer_host.h"
 #include "chrome/browser/importer/importer_list.h"
 #include "chrome/browser/infobars/infobar_tab_helper.h"
 #include "chrome/browser/instant/instant_controller.h"
 #include "chrome/browser/notifications/balloon.h"
 #include "chrome/browser/notifications/balloon_collection.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_ui_manager.h"
@@ skipping 2405 matching lines @@
 
   // SetTheme() implemented using InstallExtension().
   browser_handler_map["GetThemeInfo"] =
       &TestingAutomationProvider::GetThemeInfo;
 
   // InstallExtension() present in pyauto.py.
   browser_handler_map["GetExtensionsInfo"] =
       &TestingAutomationProvider::GetExtensionsInfo;
   browser_handler_map["UninstallExtensionById"] =
       &TestingAutomationProvider::UninstallExtensionById;
-
   browser_handler_map["SetExtensionStateById"] =
       &TestingAutomationProvider::SetExtensionStateById;
+  browser_handler_map["TriggerExtensionActionById"] =
+      &TestingAutomationProvider::TriggerExtensionActionById;
 
   browser_handler_map["FindInPage"] = &TestingAutomationProvider::FindInPage;
 
   browser_handler_map["SelectTranslateOption"] =
       &TestingAutomationProvider::SelectTranslateOption;
   browser_handler_map["GetTranslateInfo"] =
       &TestingAutomationProvider::GetTranslateInfo;
 
   browser_handler_map["GetAutofillProfile"] =
       &TestingAutomationProvider::GetAutofillProfile;
@@ skipping 1955 matching lines @@
 
   if (enable)
     service->EnableExtension(id);
   else
     service->DisableExtension(id);
 
   service->SetIsIncognitoEnabled(id, allow_in_incognito);
   reply.SendSuccess(NULL);
 }
 
+// See TriggerExtensionActionById() in chrome/test/pyautolib/pyauto.py
+// for sample json input.
+void TestingAutomationProvider::TriggerExtensionActionById(
+    Browser* browser,

[kkania, 2011/11/17 17:49:09]

could you use the new non-browser style for this and pass in a windex (see
GetBrowserFromJSONArgs) instead of passing in a browser handle. That would make
it more clean to use in chromedriver.

[frankf, 2011/11/21 02:01:46]

Done.

+    DictionaryValue* args,
+    IPC::Message* reply_message) {
+  AutomationJSONReply reply(this, reply_message);
+
+  std::string id;
+  if (!args->GetString("id", &id)) {
+    reply.SendError("Missing or invalid key: id");
+    return;
+  }
+
+  ExtensionService* service = browser->profile()->GetExtensionService();
+  if (!service) {
+    reply.SendError("No extensions service.");
+    return;
+  }
+
+  if (!service->GetInstalledExtension(id)) {
+    // The extension ID does not correspond to any extension, whether crashed
+    // or not.
+    reply.SendError(base::StringPrintf("Extension does not exist: %s.",
+                                       id.c_str()));
+    return;
+  }
+
+  const Extension* extension = service->GetExtensionById(id, false);
+  if (!extension) {
+    reply.SendError("Extension is disabled or has crashed.");
+    return;
+  }
+
+  if (extension->page_action()) {
+    int tab_id = ExtensionTabUtil::GetTabId(browser->GetSelectedTabContents());
+    service->browser_event_router()->PageActionExecuted(

[kkania, 2011/11/17 17:49:09]

I think you should throw an error if the page action is not visible for the
current page.
Optionally, it might be nice to have a func that checks whether the page action
is displayed.

[frankf, 2011/11/21 02:01:46]

Done.

+        browser->profile(), id, "action", tab_id, "", 1);
+    reply.SendSuccess(NULL);
+  } else if (extension->browser_action()) {
+    service->browser_event_router()->BrowserActionExecuted(

[kkania, 2011/11/17 17:49:09]

this doesn't work for popups

[frankf, 2011/11/21 02:01:46]

Done.

+        browser->profile(), id, browser);
+    reply.SendSuccess(NULL);
+  } else {
+    reply.SendError("Extension doesn't have any page/browser action.");
+  }
+}
+
 // Sample json input:
 //    { "command": "GetAutofillProfile" }
 // Refer to GetAutofillProfile() in chrome/test/pyautolib/pyauto.py for sample
 // json output.
 void TestingAutomationProvider::GetAutofillProfile(
     Browser* browser,
     DictionaryValue* args,
     IPC::Message* reply_message) {
   AutomationJSONReply reply(this, reply_message);
   // Get the AutofillProfiles currently in the database.
@@ skipping 1915 matching lines @@
 
   Send(reply_message_);
   redirect_query_ = 0;
   reply_message_ = NULL;
 }
 
 void TestingAutomationProvider::OnRemoveProvider() {
   if (g_browser_process)
     g_browser_process->GetAutomationProviderList()->RemoveProvider(this);
 }