chrome/browser/extensions/browser_action_apitest.cc - Issue 8587001: Have ExtensionHost use TabContents instead of RenderViewHost. Try #3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_action_apitest.cc

Issue 8587001: Have ExtensionHost use TabContents instead of RenderViewHost. Try #3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/browser_action_apitest.cc

diff --git a/chrome/browser/extensions/browser_action_apitest.cc b/chrome/browser/extensions/browser_action_apitest.cc

index 39b6f9c40c05b9cc33659780b5ccf5e78d0d921b..3b83f23707a98a95be3970cbe05b86093543edb4 100644

--- a/chrome/browser/extensions/browser_action_apitest.cc

+++ b/chrome/browser/extensions/browser_action_apitest.cc

@@ -38,7 +38,7 @@ class BrowserActionApiTest : public ExtensionApiTest {

bool OpenPopup(int index) {

ResultCatcher catcher;

ui_test_utils::WindowedNotificationObserver popup_observer(

- chrome::NOTIFICATION_EXTENSION_POPUP_VIEW_READY,

+ content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME,

content::NotificationService::AllSources());

GetBrowserActionsBar().Press(index);

popup_observer.Wait();