chrome/browser/tab_contents/render_view_host_delegate_helper.cc - Issue 8587001: Have ExtensionHost use TabContents instead of RenderViewHost. Try #3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/tab_contents/render_view_host_delegate_helper.cc

Issue 8587001: Have ExtensionHost use TabContents instead of RenderViewHost. Try #3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/tab_contents/render_view_host_delegate_helper.cc

diff --git a/chrome/browser/tab_contents/render_view_host_delegate_helper.cc b/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

index e2f25a5a8aab4239ea766c5e68dcbe8626a3974c..1f66777cc62aec43ed6cb5335454ac6773f83878 100644

--- a/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

+++ b/chrome/browser/tab_contents/render_view_host_delegate_helper.cc

@@ -549,7 +549,8 @@ WebPreferences RenderViewHostDelegateHelper::GetWebkitPrefs(

if (service) {

const Extension* extension =

service->GetExtensionByURL(rvh->site_instance()->site());

- extension_webkit_preferences::SetPreferences(&web_prefs, extension);

+ extension_webkit_preferences::SetPreferences(

+ extension, rvh->delegate()->GetRenderViewType(), &web_prefs);

}

if (rvh->delegate()->GetRenderViewType() == chrome::VIEW_TYPE_NOTIFICATION) {