chrome/browser/extensions/extension_webnavigation_api.cc - Issue 8587001: Have ExtensionHost use TabContents instead of RenderViewHost. Try #3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_webnavigation_api.cc

Issue 8587001: Have ExtensionHost use TabContents instead of RenderViewHost. Try #3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_webnavigation_api.cc

diff --git a/chrome/browser/extensions/extension_webnavigation_api.cc b/chrome/browser/extensions/extension_webnavigation_api.cc

index d80b898a9b9e85026e69df3e4990e160a45da20a..943e879a22355791ec05716d0524f81a8a35f29d 100644

--- a/chrome/browser/extensions/extension_webnavigation_api.cc

+++ b/chrome/browser/extensions/extension_webnavigation_api.cc

@@ -404,7 +404,8 @@ void ExtensionWebNavigationEventRouter::Retargeting(

ExtensionWebNavigationTabObserver* tab_observer =

ExtensionWebNavigationTabObserver::Get(details->source_tab_contents);

if (!tab_observer) {

- NOTREACHED();

+ CHECK(details->source_tab_contents->GetRenderViewType() !=

+ content::VIEW_TYPE_TAB_CONTENTS);

return;

}

const FrameNavigationState& frame_navigation_state =