Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/extensions/extension_host_mac.h

Issue 8587001: Have ExtensionHost use TabContents instead of RenderViewHost. Try #3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_MAC_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_MAC_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_MAC_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_MAC_H_
7 #pragma once 7 #pragma once
8 8
9 #include "chrome/browser/extensions/extension_host.h" 9 #include "chrome/browser/extensions/extension_host.h"
10 10
11 class RenderWidgetHostView; 11 class RenderWidgetHostView;
12 12
13 // TODO(mpcomplete): I don't know what this does or if it is needed anymore,
14 // now that ExtensionHost is restructured to rely on TabContents.
13 class ExtensionHostMac : public ExtensionHost { 15 class ExtensionHostMac : public ExtensionHost {
14 public: 16 public:
15 ExtensionHostMac(const Extension* extension, SiteInstance* site_instance, 17 ExtensionHostMac(const Extension* extension, SiteInstance* site_instance,
16 const GURL& url, content::ViewType host_type) : 18 const GURL& url, content::ViewType host_type) :
17 ExtensionHost(extension, site_instance, url, host_type) {} 19 ExtensionHost(extension, site_instance, url, host_type) {}
18 virtual ~ExtensionHostMac(); 20 virtual ~ExtensionHostMac();
19 protected:
20 virtual RenderWidgetHostView* CreateNewWidgetInternal(
21 int route_id,
22 WebKit::WebPopupType popup_type);
23 virtual void ShowCreatedWidgetInternal(RenderWidgetHostView* widget_host_view,
24 const gfx::Rect& initial_pos);
25 private: 21 private:
26 virtual void UnhandledKeyboardEvent(const NativeWebKeyboardEvent& event); 22 virtual void UnhandledKeyboardEvent(const NativeWebKeyboardEvent& event);
27 23
28 DISALLOW_COPY_AND_ASSIGN(ExtensionHostMac); 24 DISALLOW_COPY_AND_ASSIGN(ExtensionHostMac);
29 }; 25 };
30 26
31 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_MAC_H_ 27 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_HOST_MAC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698