Allows base to be built for host on android.

Allows base to be built for host on android.

ssl_false_start_blacklist_process needs to be built and executed in the host environment.

This was introduced by r95907.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111158

[Mark Mentovai, 2011-11-18 19:03:15]

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode456
base/base.gypi:456: ['include', '^sys_string_conversions_posix.cc'],
Follow the pattern of the lines around you. Fully quote the regular expression,
so . becomes \\., and anchor the end with $.

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode606
base/base.gypi:606: # ssl false start blacklist tool. We'll require further
changes
Avoid using “we” and “our” incomments.

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode614
base/base.gypi:614: ['include', 'atomicops_internals_x86_gcc\\.cc'],
^$ anchors on each end.

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode625
base/base.gypi:625: ['exclude', '^native_library_linux.cc'],
\\. and $ through line 629.

[michaelbai, 2011-11-18 23:58:16]

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode625
base/base.gypi:625: ['exclude', '^native_library_linux.cc'],
Hi Mark,

Should 'sources!' be used here instead of regular expression?

On 2011/11/18 19:03:16, Mark Mentovai wrote:
> \\. and $ through line 629.

[bulach, 2011-11-21 12:48:12]

thanks all! comments addressed, another look please?

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode456
base/base.gypi:456: ['include', '^sys_string_conversions_posix.cc'],
On 2011/11/18 19:03:16, Mark Mentovai wrote:
> Follow the pattern of the lines around you. Fully quote the regular
expression,
> so . becomes \\., and anchor the end with $.

Done.

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode606
base/base.gypi:606: # ssl false start blacklist tool. We'll require further
changes
On 2011/11/18 19:03:16, Mark Mentovai wrote:
> Avoid using “we” and “our” incomments.

Done.

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode614
base/base.gypi:614: ['include', 'atomicops_internals_x86_gcc\\.cc'],
On 2011/11/18 19:03:16, Mark Mentovai wrote:
> ^$ anchors on each end.

Done.

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode625
base/base.gypi:625: ['exclude', '^native_library_linux.cc'],
On 2011/11/18 19:03:16, Mark Mentovai wrote:
> \\. and $ through line 629.

Done.

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode625
base/base.gypi:625: ['exclude', '^native_library_linux.cc'],
On 2011/11/18 23:58:16, michaelbai wrote:
> Hi Mark,
> 
> Should 'sources!' be used here instead of regular expression?
> 
> On 2011/11/18 19:03:16, Mark Mentovai wrote:
> > \\. and $ through line 629.
> 

afaict, the order that 'sources', 'sources!' and 'sources!' are evaluated are
slightly different. I tried with 'sources!' but it didn't work...

[Mark Mentovai, 2011-11-21 13:33:55]

LGTM

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi
File base/base.gypi (right):

http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode625
base/base.gypi:625: ['exclude', '^native_library_linux.cc'],
michaelbai wrote:
> Should 'sources!' be used here instead of regular expression?

It can be if it works but doesn’t have to be.

Because of the processing order, sources! may not work. sources! doesn’t work if
a sources/ includes the file. In that case, you need to exclude it by a sources/
exclude that follows the include.

[bulach, 2011-11-21 13:43:39]

thanks! I'll put on the CQ after the try bots.

On 2011/11/21 13:33:55, Mark Mentovai wrote:
> LGTM
> 
> http://codereview.chromium.org/8586054/diff/2001/base/base.gypi
> File base/base.gypi (right):
> 
> http://codereview.chromium.org/8586054/diff/2001/base/base.gypi#newcode625
> base/base.gypi:625: ['exclude', '^native_library_linux.cc'],
> michaelbai wrote:
> > Should 'sources!' be used here instead of regular expression?
> 
> It can be if it works but doesn’t have to be.
> 
> Because of the processing order, sources! may not work. sources! doesn’t work
if
> a sources/ includes the file. In that case, you need to exclude it by a
sources/
> exclude that follows the include.

[commit-bot: I haz the power, 2011-11-22 10:20:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/8586054/7001

[commit-bot: I haz the power, 2011-11-22 10:20:39]

Can't apply patch for file base/base.gypi.
While running patch -p1 --forward --force;
patching file base/base.gypi
Hunk #1 succeeded at 451 (offset -2 lines).
Hunk #2 succeeded at 599 (offset -2 lines).
Hunk #3 FAILED at 644.
1 out of 3 hunks FAILED -- saving rejects to file base/base.gypi.rej

[commit-bot: I haz the power, 2011-11-22 14:22:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/8586054/12001

[commit-bot: I haz the power, 2011-11-22 15:33:24]

Change committed as 111158