Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: chrome/browser/extensions/extension_tabs_module_constants.cc

Issue 8586045: Add extension API to change window show state using chrome.windows.update(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Synced Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_module_constants.cc
diff --git a/chrome/browser/extensions/extension_tabs_module_constants.cc b/chrome/browser/extensions/extension_tabs_module_constants.cc
index 942235853b66a24c122bc406414180be76f0cb01..621ca8ea9e7877a1883748a8b5d07c6972253530 100644
--- a/chrome/browser/extensions/extension_tabs_module_constants.cc
+++ b/chrome/browser/extensions/extension_tabs_module_constants.cc
@@ -30,6 +30,7 @@ const char kPopulateKey[] = "populate";
const char kQualityKey[] = "quality";
const char kHighlightedKey[] = "highlighted";
const char kSelectedKey[] = "selected";
+const char kShowStateKey[] = "state";
const char kStatusKey[] = "status";
const char kTabIdKey[] = "tabId";
const char kTabIdsKey[] = "tabIds";
@@ -49,6 +50,9 @@ const char kFormatValueJpeg[] = "jpeg";
const char kFormatValuePng[] = "png";
const char kMimeTypeJpeg[] = "image/jpeg";
const char kMimeTypePng[] = "image/png";
+const char kShowStateValueNormal[] = "normal";
+const char kShowStateValueMinimized[] = "minimized";
+const char kShowStateValueMaximized[] = "maximized";
const char kStatusValueComplete[] = "complete";
const char kStatusValueLoading[] = "loading";
@@ -84,6 +88,8 @@ const char kInternalVisibleTabCaptureError[] =
"Internal error while trying to capture visible region of the current tab";
const char kNotImplementedError[] = "This call is not yet implemented";
const char kSupportedInWindowsOnlyError[] = "Supported in Windows only";
+const char kInvalidWindowTypeError[] = "Invalid value for type";
+const char kInvalidWindowStateError[] = "Invalid value for state";
const char kNoCodeOrFileToExecuteError[] = "No source code or file specified.";
const char kMoreThanOneValuesError[] = "Code and file should not be specified "
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module_constants.h ('k') | chrome/browser/extensions/extension_tabs_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698