Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3862)

Unified Diff: chrome/browser/extensions/extension_tabs_test.cc

Issue 8586045: Add extension API to change window show state using chrome.windows.update(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr feedback Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tabs_test.cc
diff --git a/chrome/browser/extensions/extension_tabs_test.cc b/chrome/browser/extensions/extension_tabs_test.cc
index dd2fbfebc505c2748b80a313b46046d1ae54f831..74e0e330dcdb89d8f2eb6d97c019f2ee3cf2e34d 100644
--- a/chrome/browser/extensions/extension_tabs_test.cc
+++ b/chrome/browser/extensions/extension_tabs_test.cc
@@ -254,3 +254,43 @@ IN_PROC_BROWSER_TEST_F(ExtensionTabsTest,
incognito_browser),
extension_tabs_module_constants::kIncognitoModeIsDisabled));
}
+
+IN_PROC_BROWSER_TEST_F(ExtensionTabsTest, InvalidUpdateWindowState) {
+ static const char kArgsMinimizedWithFocus[] =
+ "[%u, {\"state\": \"minimized\", \"focused\": true}]";
+ static const char kArgsMaximizedWithoutFocus[] =
+ "[%u, {\"state\": \"maximized\", \"focused\": false}]";
+ static const char kArgsMinimizedWithBounds[] =
+ "[%u, {\"state\": \"minimized\", \"width\": 500}]";
+ static const char kArgsMaximizedWithBounds[] =
+ "[%u, {\"state\": \"maximized\", \"width\": 500}]";
+ int window_id = ExtensionTabUtil::GetWindowId(browser());
+
+ EXPECT_TRUE(MatchPattern(
+ RunFunctionAndReturnError(
+ new UpdateWindowFunction(),
+ base::StringPrintf(kArgsMinimizedWithFocus, window_id),
+ browser()),
+ extension_tabs_module_constants::kInvalidWindowStateError));
+
+ EXPECT_TRUE(MatchPattern(
+ RunFunctionAndReturnError(
+ new UpdateWindowFunction(),
+ base::StringPrintf(kArgsMaximizedWithoutFocus, window_id),
+ browser()),
+ extension_tabs_module_constants::kInvalidWindowStateError));
+
+ EXPECT_TRUE(MatchPattern(
+ RunFunctionAndReturnError(
+ new UpdateWindowFunction(),
+ base::StringPrintf(kArgsMinimizedWithBounds, window_id),
+ browser()),
+ extension_tabs_module_constants::kInvalidWindowStateError));
+
+ EXPECT_TRUE(MatchPattern(
+ RunFunctionAndReturnError(
+ new UpdateWindowFunction(),
+ base::StringPrintf(kArgsMaximizedWithBounds, window_id),
+ browser()),
+ extension_tabs_module_constants::kInvalidWindowStateError));
+}

Powered by Google App Engine
This is Rietveld 408576698