Add extension API to change window show state using chrome.windows.update().

chrome/browser/extensions/extension_tabs_module.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tabs_module.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 512 matching lines @@
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &update_props));
 
   Browser* browser = GetBrowserInProfileWithId(profile(), window_id,
                                                include_incognito(), &error_);
   if (!browser || !browser->window()) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         keys::kWindowNotFoundError, base::IntToString(window_id));
     return false;
   }
 
-  gfx::Rect bounds = browser->window()->GetRestoredBounds();
-  bool set_bounds = false;
-  // Any part of the bounds can optionally be set by the caller.
-  int bounds_val;
-  if (update_props->HasKey(keys::kLeftKey)) {
-    EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
-        keys::kLeftKey,
-        &bounds_val));
-    bounds.set_x(bounds_val);
-    set_bounds = true;
+  ui::WindowShowState show_state = ui::SHOW_STATE_DEFAULT;  // No change.
+  std::string state_str;
+  if (update_props->HasKey(keys::kShowStateKey)) {
+    EXTENSION_FUNCTION_VALIDATE(update_props->GetString(keys::kShowStateKey,
+                                                        &state_str));
+    if (state_str == keys::kShowStateValueNormal)
+      show_state = ui::SHOW_STATE_NORMAL;
+    else if (state_str == keys::kShowStateValueMinimized)
+      show_state = ui::SHOW_STATE_MINIMIZED;
+    else if (state_str == keys::kShowStateValueMaximized)
+      show_state = ui::SHOW_STATE_MAXIMIZED;
+    else
+      EXTENSION_FUNCTION_VALIDATE(false);

[asargent_no_longer_on_chrome, 2011/11/18 18:52:24]

nit: instead of  EXTENSION_FUNCTION_VALIDATE(false), it might be better to do
something like: EXTENSION_FUNCTION_ERROR("invalid value for state");

[jennb, 2011/11/19 01:44:33]

Done.

   }
 
-  if (update_props->HasKey(keys::kTopKey)) {
-    EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
-        keys::kTopKey,
-        &bounds_val));
-    bounds.set_y(bounds_val);
-    set_bounds = true;
+  // Bounds information is ignored if minimized or maximized state is requested.

[asargent_no_longer_on_chrome, 2011/11/18 18:52:24]

Instead of ignoring, I wonder if it would make sense to consider it an error if
bounds information is passed along with setting state to minimized/maximized.
The benefit is that developers who miss reading the documentation about ignoring
bounds values would get an explicit error message instead of potentially being
surprised at the ignore behavior.

[jennb, 2011/11/19 01:44:33]

Done.

+  if (show_state == ui::SHOW_STATE_MINIMIZED) {
+    browser->window()->Minimize();
+  } else if (show_state == ui::SHOW_STATE_MAXIMIZED) {
+    browser->window()->Maximize();
+  } else {
+    if (show_state == ui::SHOW_STATE_NORMAL)
+      browser->window()->Restore();
+
+    gfx::Rect bounds = browser->window()->GetRestoredBounds();
+    bool set_bounds = false;
+
+    // Any part of the bounds can optionally be set by the caller.
+    int bounds_val;
+    if (update_props->HasKey(keys::kLeftKey)) {
+      EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
+          keys::kLeftKey,
+          &bounds_val));
+      bounds.set_x(bounds_val);
+      set_bounds = true;
+    }
+
+    if (update_props->HasKey(keys::kTopKey)) {
+      EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
+          keys::kTopKey,
+          &bounds_val));
+      bounds.set_y(bounds_val);
+      set_bounds = true;
+    }
+
+    if (update_props->HasKey(keys::kWidthKey)) {
+      EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
+          keys::kWidthKey,
+          &bounds_val));
+      bounds.set_width(bounds_val);
+      set_bounds = true;
+    }
+
+    if (update_props->HasKey(keys::kHeightKey)) {
+      EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
+          keys::kHeightKey,
+          &bounds_val));
+      bounds.set_height(bounds_val);
+      set_bounds = true;
+    }
+    if (set_bounds)
+      browser->window()->SetBounds(bounds);
   }
 
-  if (update_props->HasKey(keys::kWidthKey)) {
-    EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
-        keys::kWidthKey,
-        &bounds_val));
-    bounds.set_width(bounds_val);
-    set_bounds = true;
-  }
-
-  if (update_props->HasKey(keys::kHeightKey)) {
-    EXTENSION_FUNCTION_VALIDATE(update_props->GetInteger(
-        keys::kHeightKey,
-        &bounds_val));
-    bounds.set_height(bounds_val);
-    set_bounds = true;
-  }
-  if (set_bounds)
-    browser->window()->SetBounds(bounds);
-
   bool active_val = false;
   if (update_props->HasKey(keys::kFocusedKey)) {
     EXTENSION_FUNCTION_VALIDATE(update_props->GetBoolean(
         keys::kFocusedKey, &active_val));
-    if (active_val)
-      browser->window()->Activate();
-    else
-      browser->window()->Deactivate();
+    if (active_val) {
+      if (show_state != ui::SHOW_STATE_MINIMIZED)
+        browser->window()->Activate();
+    } else {
+      if (show_state != ui::SHOW_STATE_MAXIMIZED)
+        browser->window()->Deactivate();
+    }

[asargent_no_longer_on_chrome, 2011/11/18 18:52:24]

Same question here: would it be better to return an error if the developer made
a nonsensical request (active=true and state=minimized, or active=false and
state=maximimzed)? 

[jennb, 2011/11/19 01:44:33]

Done.

   }
 
   bool draw_attention = false;
   if (update_props->HasKey(keys::kDrawAttentionKey)) {
     EXTENSION_FUNCTION_VALIDATE(update_props->GetBoolean(
         keys::kDrawAttentionKey, &draw_attention));
     if (draw_attention)
         browser->window()->FlashFrame();
   }
 
@@ skipping 978 matching lines @@
   // called for every API call the extension made.
   GotLanguage(language);
 }
 
 void DetectTabLanguageFunction::GotLanguage(const std::string& language) {
   result_.reset(Value::CreateStringValue(language.c_str()));
   SendResponse(true);
 
   Release();  // Balanced in Run()
 }