Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 8586044: GTK: Make the gtk port compile with GTK_DISABLE_SINGLE_INCLUDES. (Closed)

Created:
9 years, 1 month ago by Elliot Glaysher
Modified:
9 years, 1 month ago
Reviewers:
Lei Zhang, Evan Stade
CC:
chromium-reviews, yusukes+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, dhollowa
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Make the gtk port compile with GTK_DISABLE_SINGLE_INCLUDES. BUG=79722 TEST=none TBR=tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111090

Patch Set 1 #

Patch Set 2 : Restrict compile flags to the GTK port #

Patch Set 3 : test shell tests fix #

Patch Set 4 : Remove views/. Not our problem for gtk3 porting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -30 lines) Patch
M build/common.gypi View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/printing/print_dialog_gtk.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_gtk.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_accelerators_gtk.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/bubble/bubble_accelerators_gtk.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/chrome_gtk_frame.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_button.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_custom_menu.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_custom_menu_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_input_event_box.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_input_event_box.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/gpu/gpu_process_host_ui_shim.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M printing/print_settings_initializer_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_gtk.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/base/gtk/gtk_floating_container.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M ui/gfx/gtk_preserve_window.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/gfx/insets.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/skia_utils_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
also whoever gets to it first
9 years, 1 month ago (2011-11-21 18:48:52 UTC) #1
Lei Zhang
lgtm
9 years, 1 month ago (2011-11-21 22:44:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8586044/7001
9 years, 1 month ago (2011-11-21 23:16:51 UTC) #3
commit-bot: I haz the power
Presubmit check for 8586044-7001 failed and returned exit status 1. Running presubmit commit checks ...
9 years, 1 month ago (2011-11-21 23:17:00 UTC) #4
Elliot Glaysher
TBR tony: one line fix to a wrong gtk include in test shell.
9 years, 1 month ago (2011-11-22 01:09:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/8586044/7001
9 years, 1 month ago (2011-11-22 01:09:23 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 03:12:33 UTC) #7
Change committed as 111090

Powered by Google App Engine
This is Rietveld 408576698