Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 8586043: Adds an option item that enables/disables the Spelling service. (Closed)

Created:
9 years, 1 month ago by Hironori Bono
Modified:
9 years, 1 month ago
Reviewers:
csilv, Evan Stade
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Adds an option item that enables/disables using the Spelling service. This change re-enables a check-box item "Use a web service to help resolve spelling errors", which allows users to stop using the Spelling service, on Win Chrome. BUG=103840 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110890

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/resources/options/advanced_options.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/advanced_options_handler.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Hironori Bono
9 years, 1 month ago (2011-11-17 22:49:17 UTC) #1
csilv
lgtm http://codereview.chromium.org/8586043/diff/1/chrome/browser/resources/options/advanced_options.html File chrome/browser/resources/options/advanced_options.html (right): http://codereview.chromium.org/8586043/diff/1/chrome/browser/resources/options/advanced_options.html#newcode43 chrome/browser/resources/options/advanced_options.html:43: metric="Options_UseSpellingCheckbox" type="checkbox"> Should the metric be "Options_UseSpellingServiceCheckbox" instead? ...
9 years, 1 month ago (2011-11-19 01:37:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hbono@chromium.org/8586043/6001
9 years, 1 month ago (2011-11-21 04:40:46 UTC) #3
Hironori Bono
http://codereview.chromium.org/8586043/diff/1/chrome/browser/resources/options/advanced_options.html File chrome/browser/resources/options/advanced_options.html (right): http://codereview.chromium.org/8586043/diff/1/chrome/browser/resources/options/advanced_options.html#newcode43 chrome/browser/resources/options/advanced_options.html:43: metric="Options_UseSpellingCheckbox" type="checkbox"> On 2011/11/19 01:37:53, csilv wrote: > Should ...
9 years, 1 month ago (2011-11-21 04:44:32 UTC) #4
Hironori Bono
Greeting, Thanks you for your review and comment. Regards, Hironori Bono On 2011/11/21 04:44:32, Hironori ...
9 years, 1 month ago (2011-11-21 04:45:00 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-21 06:16:51 UTC) #6
Change committed as 110890

Powered by Google App Engine
This is Rietveld 408576698