Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: client/testing/unittest/shared.dart

Issue 8586041: Fix to workaround non-propagation of exception stack-traces by dartc. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/testing/unittest/shared.dart
===================================================================
--- client/testing/unittest/shared.dart (revision 1630)
+++ client/testing/unittest/shared.dart (working copy)
@@ -159,9 +159,6 @@
/** Runs a single test. */
_runTest(TestCase testCase) {
try {
- // TODO(sigmund): remove this declaration once dartc supports trapping error
- // traces.
- var trace = '';
_callbacksCalled = 0;
_state = _RUNNING_TEST;
@@ -175,11 +172,13 @@
} catch (ExpectException e, var trace) {
if (_state != _UNCAUGHT_ERROR) {
- testCase.fail(e.message, trace.toString());
+ //TODO remove guard once dartc reliably propagates traces
Siggi Cherem (dart-lang) 2011/11/17 22:03:59 TODO -> TODO(pquitslund) or TODO(sigmund)
+ testCase.fail(e.message, trace == null ? '' : trace.toString());
}
} catch (var e, var trace) {
if (_state != _UNCAUGHT_ERROR) {
- testCase.error('Caught ${e}', trace.toString());
+ //TODO remove guard once dartc reliably propagates traces
+ testCase.error('Caught ${e}', trace == null ? '' : trace.toString());
}
} finally {
_state = _READY;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698