Implement WebThread::{add,remove}TaskObserver.

Implement WebThread::{add,remove}TaskObserver.

Depends on http://trac.webkit.org/changeset/101418

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113010

[darin (slow to review), 2011-11-30 06:45:38]

LGTM

http://codereview.chromium.org/8586038/diff/3001/webkit/glue/webthread_impl.cc
File webkit/glue/webthread_impl.cc (right):

http://codereview.chromium.org/8586038/diff/3001/webkit/glue/webthread_impl.c...
webkit/glue/webthread_impl.cc:71: return thread_->thread_id() ==
base::PlatformThread::CurrentId();
it feels like this should be a method on the Thread class.

[adamk, 2011-11-30 21:58:24]

http://codereview.chromium.org/8586038/diff/3001/webkit/glue/webthread_impl.cc
File webkit/glue/webthread_impl.cc (right):

http://codereview.chromium.org/8586038/diff/3001/webkit/glue/webthread_impl.c...
webkit/glue/webthread_impl.cc:71: return thread_->thread_id() ==
base::PlatformThread::CurrentId();
On 2011/11/30 06:45:39, darin wrote:
> it feels like this should be a method on the Thread class.

Yeah...I think this doesn't come up too often because people store thread_id()
in a member.

[Avi (use Gerrit), 2011-12-05 20:49:10]

Reverted in r113014.

./webkit/glue/webthread_impl.h:16:1:error: [chromium-style] Complex class/struct
needs an explicit out-of-line constructor.
class WebThreadBase : public WebKit::WebThread {
^
./webkit/glue/webthread_impl.h:16:1:error: [chromium-style] Complex class/struct
needs an explicit out-of-line destructor.
./webkit/glue/webthread_impl.h:41:11:error: [chromium-style] Overriding method
must be marked with OVERRIDE.
  virtual bool IsCurrentThread() const;
          ^
./webkit/glue/webthread_impl.h:56:11:error: [chromium-style] Overriding method
must be marked with OVERRIDE.
  virtual bool IsCurrentThread() const;
          ^

Use trybots. That's what they're there for.

[adamk, 2011-12-05 21:19:57]

On 2011/12/05 20:49:10, Avi wrote:
> Reverted in r113014.
> 
> ./webkit/glue/webthread_impl.h:16:1:error: [chromium-style] Complex
class/struct
> needs an explicit out-of-line constructor.
> class WebThreadBase : public WebKit::WebThread {
> ^
> ./webkit/glue/webthread_impl.h:16:1:error: [chromium-style] Complex
class/struct
> needs an explicit out-of-line destructor.
> ./webkit/glue/webthread_impl.h:41:11:error: [chromium-style] Overriding method
> must be marked with OVERRIDE.
>   virtual bool IsCurrentThread() const;
>           ^
> ./webkit/glue/webthread_impl.h:56:11:error: [chromium-style] Overriding method
> must be marked with OVERRIDE.
>   virtual bool IsCurrentThread() const;
>           ^
> 
> Use trybots. That's what they're there for.

For the record: I thought I'd trybot'd this, but lost state due to the >2week
delay in landing it. It'd be nice if the presubmit would warn if it sees no try
jobs (rather than just failed tryjobs)...