Issue 8586033: Fixes use after free in BrowserView, and cleans up a couple of style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8586033: Fixes use after free in BrowserView, and cleans up a couple of style (Closed)

Created:
9 years, 1 month ago by sky

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes use after free in BrowserView, and cleans up a couple of style nits I noticed along the way. BUG=104387 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110579

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -6 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view.cc	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/fullscreen_exit_bubble_views.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/fullscreen_exit_bubble_views.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/8586033/1

9 years, 1 month ago (2011-11-17 21:08:25 UTC) #3

Change committed as 110579