Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 8586032: Remove the flags to RenderViewHost::EnablePreferredSizeMode since it's not used after http://crbu... (Closed)

Created:
9 years, 1 month ago by jam
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, Avi (use Gerrit), jennb, creis+watch_chromium.org, prasadt, Erik does not do reviews, Dmitry Titov, jam, mihaip+watch_chromium.org, dcheng, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, jianli, brettw-cc_chromium.org, ajwong+watch_chromium.org, levin
Visibility:
Public.

Description

Remove the flags to RenderViewHost::EnablePreferredSizeMode since it's not used after http://crbug.com/44850 was fixed. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110539

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -27 lines) Patch
M chrome/browser/extensions/extension_host.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/balloon_host.cc View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/panels/panel.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/view_message_enums.h View 1 chunk +0 lines, -9 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
9 years, 1 month ago (2011-11-17 18:33:30 UTC) #1
jennb
Thanks for cleaning this up, but I think levin@ might be refactoring this area to ...
9 years, 1 month ago (2011-11-17 18:39:01 UTC) #2
Nico
LGTM Thanks! Also thanks to levin for fixing that bug.
9 years, 1 month ago (2011-11-17 18:40:31 UTC) #3
jam
David: are you removing that function now? I'm trying to bring down includes of view_messages.h ...
9 years, 1 month ago (2011-11-17 18:41:50 UTC) #4
jennb
9 years, 1 month ago (2011-11-17 19:53:12 UTC) #5
Talked to David. He said go ahead with your patch. He's not ready with
his patch yet.

On Thu, Nov 17, 2011 at 10:41 AM, John Abd-El-Malek <jam@chromium.org> wrote:
> David: are you removing that function now? I'm trying to bring down includes
> of view_messages.h in chrome to 0, so that we can enforce it with DEPS
> rules. If you don't have a change out for this, then this change shouldn't
> make a difference when you remove the whole function.
>
> On Thu, Nov 17, 2011 at 10:39 AM, <jennb@chromium.org> wrote:
>>
>> Thanks for cleaning this up, but I think levin@ might be refactoring this
>> area
>> to remove that function completely.
>>
>> http://codereview.chromium.org/8586032/
>
>

Powered by Google App Engine
This is Rietveld 408576698