Convert a few ppapi dev interfaces to IDL. NaCl has tests for these

ppapi/c/dev/ppp_printing_dev.h

Index: ppapi/c/dev/ppp_printing_dev.h
diff --git a/ppapi/c/dev/ppp_printing_dev.h b/ppapi/c/dev/ppp_printing_dev.h
index cd83d458ea9b8638b9b5ac0df5dbfb73a7e1f8f0..5ff30c1bc51d80ecf3187e7f7f4939d6f7336df9 100644
--- a/ppapi/c/dev/ppp_printing_dev.h
+++ b/ppapi/c/dev/ppp_printing_dev.h
@@ -2,32 +2,57 @@
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
+
+/* From dev/ppp_printing_dev.idl modified Thu Nov 17 09:51:33 2011. */
+
 #ifndef PPAPI_C_DEV_PPP_PRINTING_DEV_H_
 #define PPAPI_C_DEV_PPP_PRINTING_DEV_H_
 
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_instance.h"
 #include "ppapi/c/pp_macros.h"
+#include "ppapi/c/pp_point.h"
 #include "ppapi/c/pp_rect.h"
 #include "ppapi/c/pp_resource.h"
+#include "ppapi/c/pp_size.h"
 #include "ppapi/c/pp_stdint.h"
 
+#define PPP_PRINTING_DEV_INTERFACE_0_5 "PPP_Printing(Dev);0.5"
+#define PPP_PRINTING_DEV_INTERFACE PPP_PRINTING_DEV_INTERFACE_0_5
+
+/**
+ * @file
+ * Implementation of the Printing interface.
+ */
+
+
+/**
+ * @addtogroup Enums
+ * @{
+ */
 typedef enum {
-  PP_PRINTORIENTATION_NORMAL         = 0,
-  PP_PRINTORIENTATION_ROTATED_90_CW  = 1,
-  PP_PRINTORIENTATION_ROTATED_180    = 2,
+  PP_PRINTORIENTATION_NORMAL = 0,
+  PP_PRINTORIENTATION_ROTATED_90_CW = 1,
+  PP_PRINTORIENTATION_ROTATED_180 = 2,
   PP_PRINTORIENTATION_ROTATED_90_CCW = 3
 } PP_PrintOrientation_Dev;
 PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_PrintOrientation_Dev, 4);
 
 typedef enum {
-  PP_PRINTOUTPUTFORMAT_RASTER     = 1u << 0,
-  PP_PRINTOUTPUTFORMAT_PDF        = 1u << 1,
-  PP_PRINTOUTPUTFORMAT_POSTSCRIPT = 1u << 2,
-  PP_PRINTOUTPUTFORMAT_EMF        = 1u << 3
+  PP_PRINTOUTPUTFORMAT_RASTER = 1 << 0,
+  PP_PRINTOUTPUTFORMAT_PDF = 1 << 1,
+  PP_PRINTOUTPUTFORMAT_POSTSCRIPT = 1 << 2,
+  PP_PRINTOUTPUTFORMAT_EMF = 1 << 3

[dmichael (off chromium), 2011/11/17 19:04:41]

yipe... we should probably still use unsigned literals here, since we're
shifting and these are used in a uint32_t bitfield (though it *probably* doesn't
matter in this case; not sure)

[jvoung - send to chromium..., 2011/11/17 20:51:34]

Left shifts should be okay, right (no sign extension issues)?

[dmichael (off chromium), 2011/11/17 21:05:49]

Yeah, it should give the value you want. I was concerned about the type. enums
always have an integral type, but *what* integral type it is can depend on the
value. These are used in a context where uint32_t is desired (they're or-ed
together), so I'd rather the enum values have the right type. That said...  I
don't think we really know what type the enum uses in this case (though you can
force it by making it store a std::numeric_limits::max<uint32_t>(), for
example). So we probably have to cast to uint32_t where these are used anyway,
hence, it *probably* doesn't matter.

All that said, even if it works fine, I don't really see the point in changing
it from unsigned (the type we ultimately want) to signed.

[jvoung - send to chromium..., 2011/11/17 22:00:09]

Done.

 } PP_PrintOutputFormat_Dev;
 PP_COMPILE_ASSERT_SIZE_IN_BYTES(PP_PrintOutputFormat_Dev, 4);
+/**
+ * @}
+ */
 
+/**
+ * @addtogroup Structs
+ * @{
+ */
 struct PP_PrintSettings_Dev {
   /** This is the size of the printable area in points (1/72 of an inch) */
   struct PP_Rect printable_area;
@@ -47,11 +72,14 @@ struct PP_PrintPageNumberRange_Dev {
   uint32_t last_page_number;
 };
 PP_COMPILE_ASSERT_STRUCT_SIZE_IN_BYTES(PP_PrintPageNumberRange_Dev, 8);
+/**
+ * @}
+ */
 
-/* Interface for the plugin to implement printing. */
-#define PPP_PRINTING_DEV_INTERFACE_0_5 "PPP_Printing(Dev);0.5"
-#define PPP_PRINTING_DEV_INTERFACE PPP_PRINTING_DEV_INTERFACE_0_5
-
+/**
+ * @addtogroup Interfaces
+ * @{
+ */
 struct PPP_Printing_Dev {
   /**
    *  Returns a bit field representing the supported print output formats.  For
@@ -60,7 +88,6 @@ struct PPP_Printing_Dev {
    *  (PP_PRINTOUTPUTFORMAT_RASTER | PP_PRINTOUTPUTFORMAT_POSTSCRIPT)
    */
   uint32_t (*QuerySupportedFormats)(PP_Instance instance);
-
   /**
    * Begins a print session with the given print settings. Calls to PrintPage
    * can only be made after a successful call to Begin. Returns the number of
@@ -69,7 +96,6 @@ struct PPP_Printing_Dev {
    */
   int32_t (*Begin)(PP_Instance instance,
                    const struct PP_PrintSettings_Dev* print_settings);
-
   /**
    * Prints the specified pages using the format specified in Begin.
    * Returns a resource that represents the printed output.
@@ -81,16 +107,17 @@ struct PPP_Printing_Dev {
       PP_Instance instance,
       const struct PP_PrintPageNumberRange_Dev* page_ranges,
       uint32_t page_range_count);
-
   /** Ends the print session. Further calls to PrintPage will fail. */
   void (*End)(PP_Instance instance);
-
   /**
    *  Returns true if the current content should be printed into the full page
    *  and not scaled down to fit within the printer's printable area.
    */
   PP_Bool (*IsScalingDisabled)(PP_Instance instance);
 };
+/**
+ * @}
+ */
 
 #endif  /* PPAPI_C_DEV_PPP_PRINTING_DEV_H_ */