Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/policy/configuration_policy_provider.h

Issue 8586030: Added ConfigurationPolicyProvider::RefreshPolicies. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed LoginUtilsTest Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/configuration_policy_provider.h
diff --git a/chrome/browser/policy/configuration_policy_provider.h b/chrome/browser/policy/configuration_policy_provider.h
index efe93cda4ee737530c26d3908695e81579846c60..f07dec0caac33ec036f93ac22d1d7b190971068c 100644
--- a/chrome/browser/policy/configuration_policy_provider.h
+++ b/chrome/browser/policy/configuration_policy_provider.h
@@ -28,8 +28,8 @@ class ConfigurationPolicyProvider {
class Observer {
public:
virtual ~Observer();
- virtual void OnUpdatePolicy() = 0;
- virtual void OnProviderGoingAway();
+ virtual void OnUpdatePolicy(ConfigurationPolicyProvider* provider) = 0;
+ virtual void OnProviderGoingAway(ConfigurationPolicyProvider* provider);
};
explicit ConfigurationPolicyProvider(const PolicyDefinitionList* policy_list);
@@ -54,6 +54,13 @@ class ConfigurationPolicyProvider {
void OverridePolicies(PolicyMap* policies);
#endif
+ // Asks the provider to refresh its policies. All the updates caused by this
+ // call will be visible on the next calls of OnUpdatePolicy on the observers,
Mattias Nissler (ping if slow) 2011/11/21 16:09:05 s/calls/call/? I think grammar-wise it's correct t
Joao da Silva 2011/11/21 16:49:21 Done. The practice of german and the black horse a
+ // which are guaranteed to happen even if the refresh fails.
+ // It is possible that OnProviderGoingAway is called first though, and
+ // OnUpdatePolicy won't be called if that happens.
+ virtual void RefreshPolicies() = 0;
+
protected:
// Sends a policy update notification to observers.
void NotifyPolicyUpdated();
@@ -100,8 +107,8 @@ class ConfigurationPolicyObserverRegistrar
ConfigurationPolicyProvider::Observer* observer);
// ConfigurationPolicyProvider::Observer implementation:
- virtual void OnUpdatePolicy();
- virtual void OnProviderGoingAway();
+ virtual void OnUpdatePolicy(ConfigurationPolicyProvider* provider);
+ virtual void OnProviderGoingAway(ConfigurationPolicyProvider* provider);
ConfigurationPolicyProvider* provider() { return provider_; }

Powered by Google App Engine
This is Rietveld 408576698