Move DNS resolution from websocket-to-TCP proxy to ExtensionFunction

chrome/browser/extensions/extension_web_socket_proxy_private_api.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_WEB_SOCKET_PROXY_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_WEB_SOCKET_PROXY_PRIVATE_API_H_
 #pragma once
 
 #include "base/timer.h"
 #include "chrome/browser/extensions/extension_function.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
+#include "net/base/address_list.h"
 
+namespace net {
+class SingleRequestHostResolver;
+}
+
+// Base class for web socket proxy functions.
 class WebSocketProxyPrivate
     : public AsyncExtensionFunction, public content::NotificationObserver {
  public:
   WebSocketProxyPrivate();
-
   virtual ~WebSocketProxyPrivate();
 
-  // Finalizes async operation.
-  virtual void Finalize();
+ protected:
+  // Custom finalization.
+  virtual void CustomFinalize() = 0;
 
- protected:
-  // content::NotificationObserver implementation.
-  virtual void Observe(
-      int type, const content::NotificationSource& source,
-      const content::NotificationDetails& details) OVERRIDE;
-
-  // Whether already finalized.
-  bool is_finalized_;
-
-  // Used to signal timeout (when waiting for proxy initial launch).
-  base::OneShotTimer<WebSocketProxyPrivate> timer_;
-
-  content::NotificationRegistrar registrar_;
-
-  // Proxy accepts websocket connections on this port.
-  int listening_port_;
-};
-
-class WebSocketProxyPrivateGetURLForTCPFunction
-    : public WebSocketProxyPrivate {
- private:
   // ExtensionFunction implementation.
   virtual bool RunImpl() OVERRIDE;
 
   // content::NotificationObserver implementation.
   virtual void Observe(
       int type, const content::NotificationSource& source,
       const content::NotificationDetails& details) OVERRIDE;
 
-  // Finalizes async operation.
-  virtual void Finalize() OVERRIDE;
+  // Destination hostname.
+  std::string hostname_;
+  // Destination IP address.
+  net::AddressList addr_;
+  // Destination port.
+  int port_;
+  // Proxy accepts websocket connections on this port.
+  int listening_port_;
+  // Whether TLS should be used.
+  bool do_tls_;
+  // Requested parameters of connection.
+  std::map<std::string, std::string> map_;
 
-  // Query component of resulting URL.
-  std::string query_;
+ private:
+  // Finalizes and sends respond. Overwrite 'CustomFinalize' in inherited
+  // classes.
+  void Finalize();
 
-  DECLARE_EXTENSION_FUNCTION_NAME("webSocketProxyPrivate.getURLForTCP")
+  // Callback for DNS resolution.
+  void OnHostResolution(int result);
+
+  // Executes on IO thread. Performs DNS resolution.
+  void ResolveHost();
+
+  // Used to signal timeout (when waiting for proxy initial launch).
+  base::OneShotTimer<WebSocketProxyPrivate> timer_;
+  // Used to register for notifications.
+  content::NotificationRegistrar registrar_;
+  // Used to cancel host resolution when out of scope.
+  scoped_ptr<net::SingleRequestHostResolver> resolver_;
+  // Callback which is called when host is resolved.
+  bool is_finalized_;
 };
 
-// Legacy, deprecated, to be eliminated.
-class WebSocketProxyPrivateGetPassportForTCPFunction
+// New API function for web socket proxy, which should be used.
+class WebSocketProxyPrivateGetURLForTCPFunction
     : public WebSocketProxyPrivate {
  public:
-  WebSocketProxyPrivateGetPassportForTCPFunction();
+  WebSocketProxyPrivateGetURLForTCPFunction();
+  virtual ~WebSocketProxyPrivateGetURLForTCPFunction();
 
  private:
   // ExtensionFunction implementation.
   virtual bool RunImpl() OVERRIDE;
 
+  // WebSocketProxyPrivate implementation:
+  virtual void CustomFinalize() OVERRIDE;
+
+  DECLARE_EXTENSION_FUNCTION_NAME("webSocketProxyPrivate.getURLForTCP")
+};
+
+// Legacy API function for web socket proxy, to be eliminated.
+class WebSocketProxyPrivateGetPassportForTCPFunction
+    : public WebSocketProxyPrivate {
+ public:
+  WebSocketProxyPrivateGetPassportForTCPFunction();
+  virtual ~WebSocketProxyPrivateGetPassportForTCPFunction();
+
+ private:
+  // WebSocketProxyPrivate implementation:
+  virtual void CustomFinalize() OVERRIDE;
+
   DECLARE_EXTENSION_FUNCTION_NAME("webSocketProxyPrivate.getPassportForTCP")
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_WEB_SOCKET_PROXY_PRIVATE_API_H_