Issue 8586025: Removing exit time destructors by leaking static members.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8586025: Removing exit time destructors by leaking static members. (Closed)

Created:
9 years, 1 month ago by Yang

Modified:
9 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removing exit time destructors by leaking static members. Note that some cctests and d8 still contain statical members with exit time destructors. BUG=v8:1828 Committed: http://code.google.com/p/v8/source/detail?r=10025

Patch Set 1 #

Patch Set 2 : Macro-fied the elements accessor list. #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -45 lines)			Patch
M	src/ast.h	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/ast.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/elements.cc	View	1	1 chunk	+33 lines, -31 lines	1 comment	Download
M	src/extensions/gc-extension.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/hashmap.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/hashmap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/parser.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/scopes.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years, 1 month ago (2011-11-17 14:38:16 UTC) #3

LGTM with a comment.

http://codereview.chromium.org/8586025/diff/10/src/elements.cc
File src/elements.cc (right):

http://codereview.chromium.org/8586025/diff/10/src/elements.cc#newcode804
src/elements.cc:804: // First argument in list is the accessor class, the second
argument is can
Please add a comment that the order must match that of the ElementsKind enum for
the |accessor_array[]| below to work.

Expand Messages | Collapse Messages