ForTest presubmit check non-failing for CQ by making it just a message

ForTest presubmit check non-failing for CQ by making it just a message
instead of a warning on commit, since there continue to be occasional
fale positives and to fix the last ones the presubmit script would
need to invoke a full C++ parser.

Update the warning text.

BUG=none
TEST=dev tested locally on a specially set-up branch with various
files that tickle the presubmit test.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110690

[M-A Ruel, 2011-11-17 20:16:57]

http://codereview.chromium.org/8586024/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8586024/diff/1/PRESUBMIT.py#newcode102
PRESUBMIT.py:102: if not committing:
Use input_api.is_committing instead. It will simplify the change.

[Jói, 2011-11-18 10:31:21]

PTAL

On Thu, Nov 17, 2011 at 8:16 PM,  <maruel@chromium.org> wrote:
>
> http://codereview.chromium.org/8586024/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
>
> http://codereview.chromium.org/8586024/diff/1/PRESUBMIT.py#newcode102
> PRESUBMIT.py:102: if not committing:
> Use input_api.is_committing instead. It will simplify the change.
>
> http://codereview.chromium.org/8586024/
>

[M-A Ruel, 2011-11-18 11:26:49]

lgtm

http://codereview.chromium.org/8586024/diff/4001/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/8586024/diff/4001/PRESUBMIT.py#newcode50
PRESUBMIT.py:50: def _CheckNoProductionCodeUsingTestOnlyFunctions(input_api,
Not necessary. :)

[Jói, 2011-11-18 12:44:55]

Fixed, committing now.

On Fri, Nov 18, 2011 at 11:26 AM,  <maruel@chromium.org> wrote:
> lgtm
>
>
> http://codereview.chromium.org/8586024/diff/4001/PRESUBMIT.py
> File PRESUBMIT.py (right):
>
> http://codereview.chromium.org/8586024/diff/4001/PRESUBMIT.py#newcode50
> PRESUBMIT.py:50: def
> _CheckNoProductionCodeUsingTestOnlyFunctions(input_api,
> Not necessary. :)
>
> http://codereview.chromium.org/8586024/
>