Treat assignment to final as an error

frog/value.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Represents a meta-value for code generation.
  */
 class Value {
   /** The [Type] of the [Value]. */
   Type type;
 
   /** The javascript code to generate this value. */
   String code;
 
   /** The source location that created this value for error messages. */
   SourceSpan span;
 
   /** Is this a reference to super? */
   bool isSuper = false;
 
   /** Is this a pretend first-class type? */
   bool isType = false;
 
+  /** Is this a final variable? */
+  bool isFinal = false;

[jimhug, 2011/11/17 15:36:15]

Okay for now - but this is a reminder that I need to get back to my refactoring
of Value to reduce the amount of state we keep here and use subtypes when
appropropriate.

+
   /** If we reference this value multiple times, do we need a temp? */
   bool needsTemp;
 
   // TODO(jmesserly): until reified generics are fixed, treat ParameterType as
   // "var".
   bool get _typeIsVarOrParameterType() => type.isVar || type is ParameterType;
 
   Value(this.type, this.code, this.span, [this.needsTemp = true]) {
     if (type == null) world.internalError('type passed as null', span);
   }
@@ skipping 665 matching lines @@
 
     // Then look for members in my library.
     member = home.library.lookup(name, span);
     if (member != null) {
       return member;
     }
 
     return null;
   }
 }