Slow start pipelining.

net/http/http_pipelined_host_impl.cc

Index: net/http/http_pipelined_host_impl.cc
diff --git a/net/http/http_pipelined_host_impl.cc b/net/http/http_pipelined_host_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f125ef7003b61f3cedbc96bc3eaf719f1a256cd3
--- /dev/null
+++ b/net/http/http_pipelined_host_impl.cc
@@ -0,0 +1,174 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "net/http/http_pipelined_host_impl.h"
+
+#include "base/stl_util.h"
+#include "net/http/http_pipelined_connection_impl.h"
+#include "net/http/http_pipelined_stream.h"
+
+namespace net {
+
+// TODO(simonjam): Run experiments to see what value minimizes evictions without
+// costing too much performance. Until then, this is just a bad guess.
+static const int kNumKnownSuccessesThreshold = 3;
+
+class HttpPipelinedConnectionImplFactory :
+    public HttpPipelinedConnection::Factory {
+ public:
+  HttpPipelinedConnection* CreateNewPipeline(
+      ClientSocketHandle* connection,
+      HttpPipelinedConnection::Delegate* delegate,
+      const SSLConfig& used_ssl_config,
+      const ProxyInfo& used_proxy_info,
+      const BoundNetLog& net_log,
+      bool was_npn_negotiated) OVERRIDE {
+    return new HttpPipelinedConnectionImpl(connection, delegate,
+                                           used_ssl_config, used_proxy_info,
+                                           net_log, was_npn_negotiated);
+  }
+};
+
+HttpPipelinedHostImpl::HttpPipelinedHostImpl(
+    HttpPipelinedHost::Delegate* delegate,
+    const HostPortPair& origin,
+    HttpPipelinedConnection::Factory* factory,
+    Capability capability)
+    : delegate_(delegate),
+      origin_(origin),
+      factory_(factory),
+      capability_(capability) {
+  if (!factory) {
+    factory_.reset(new HttpPipelinedConnectionImplFactory());
+  }
+}
+
+HttpPipelinedHostImpl::~HttpPipelinedHostImpl() {
+  CHECK(pipelines_.empty());
+}
+
+HttpPipelinedStream* HttpPipelinedHostImpl::CreateStreamOnNewPipeline(
+    ClientSocketHandle* connection,
+    const SSLConfig& used_ssl_config,
+    const ProxyInfo& used_proxy_info,
+    const BoundNetLog& net_log,
+    bool was_npn_negotiated) {
+  HttpPipelinedConnection* pipeline = factory_->CreateNewPipeline(
+      connection, this, used_ssl_config, used_proxy_info, net_log,
+      was_npn_negotiated);
+  PipelineInfo info;
+  switch (capability_) {
+    case CAPABLE:
+      info.capacity = max_pipeline_depth();
+      break;
+
+    case INCAPABLE:
+      CHECK(false);
+
+    case UNKNOWN:
+      info.capacity = 1;
+      break;
+  }
+  pipelines_.insert(std::make_pair(pipeline, info));
+  return pipeline->CreateNewStream();
+}
+
+HttpPipelinedStream* HttpPipelinedHostImpl::CreateStreamOnExistingPipeline() {
+  HttpPipelinedConnection* available_pipeline = NULL;
+  for (PipelineInfoMap::iterator it = pipelines_.begin();
+       it != pipelines_.end(); ++it) {
+    if (it->first->usable() &&
+        it->first->active() &&
+        it->first->depth() < it->second.capacity &&
+        (!available_pipeline ||
+         it->first->depth() < available_pipeline->depth())) {
+      available_pipeline = it->first;
+    }
+  }
+  if (!available_pipeline) {
+    return NULL;
+  }
+  return available_pipeline->CreateNewStream();
+}
+
+bool HttpPipelinedHostImpl::IsExistingPipelineAvailable() {
+  for (PipelineInfoMap::iterator it = pipelines_.begin();
+       it != pipelines_.end(); ++it) {
+    if (it->first->usable() &&
+        it->first->active() &&
+        it->first->depth() < it->second.capacity) {
+      return true;
+    }
+  }
+  return false;
+}
+
+const HostPortPair& HttpPipelinedHostImpl::origin() const {
+  return origin_;
+}
+
+void HttpPipelinedHostImpl::OnPipelineEmpty(HttpPipelinedConnection* pipeline) {
+  CHECK(ContainsKey(pipelines_, pipeline));
+  if (capability_ == UNKNOWN &&
+      pipelines_[pipeline].num_successes >= kNumKnownSuccessesThreshold) {
+    capability_ = CAPABLE;
+    delegate_->OnHostDeterminedCapability(this, CAPABLE);
+  }
+  pipelines_.erase(pipeline);
+  delete pipeline;
+  if (pipelines_.empty()) {
+    delegate_->OnHostIdle(this);
+    // WARNING: We'll probably be deleted here.
+  }
+}
+
+void HttpPipelinedHostImpl::OnPipelineHasCapacity(
+    HttpPipelinedConnection* pipeline) {
+  CHECK(ContainsKey(pipelines_, pipeline));
+  if (pipeline->usable() &&
+      capability_ != INCAPABLE &&
+      pipeline->depth() < pipelines_[pipeline].capacity) {
+    delegate_->OnHostHasAdditionalCapacity(this);
+  }
+  if (!pipeline->depth()) {
+    OnPipelineEmpty(pipeline);
+    // WARNING: We might be deleted here.
+  }
+}
+
+void HttpPipelinedHostImpl::OnPipelineFeedback(
+    HttpPipelinedConnection* pipeline,
+    HttpPipelinedConnection::Feedback feedback) {
+  CHECK(ContainsKey(pipelines_, pipeline));
+  switch (feedback) {
+    case HttpPipelinedConnection::OK:
+      ++pipelines_[pipeline].num_successes;
+      if (pipelines_[pipeline].capacity != max_pipeline_depth()) {
+        pipelines_[pipeline].capacity = max_pipeline_depth();
+        OnPipelineHasCapacity(pipeline);
+      }
+      break;
+
+    case HttpPipelinedConnection::SOCKET_ERROR:
+      // TODO(simonjam): How often do we get spurious errors? Maybe we should
+      // just ignore these unless they're common. Until then, fall through...

[mmenke, 2011/11/17 22:25:37]

Just think of the case of losing a network connection, or spotty 4G.  Or a
computer going to sleep with sockets active.   That last one will result in
ERR_ABORTED, I believe, so can handle that particular case specifically, but
there are a whole host of other possible failure reasons.

[James Simonsen, 2011/11/18 00:03:56]

Okay, I think a whitelist is the safest thing to do. I'll implement that in the
connection. It's hard to know which errors we're likely to see and whether they
can be ignored. I erred on the safe side.

[mmenke, 2011/11/21 14:51:39]

Consider what servers that don't support pipelining are likely to do.  Note that
these are just fairly uneducated guesses based on no actual data.

They can:

1)  Abruptly close the connection immediately (ERR_CONNECTION_CLOSED /
ERR_EMPTY_RESPONSE on the socket, maybe ERR_CONTENT_LENGTH_MISMATCH on the
stream).
2)  Close the connection after sending the current file (ERR_EMPTY_RESPONSE)
3)  Intermingle responses for two requests.
4)  Ignore pipelined requests and just respond to the next request it sees, if
any, after servicing the first request.
5)  Hang?

All of the error codes in 1) and 2) can probably also occur as a result of
connection errors.  At least it's not uncommon for me to see those errors when
my router is mad.

3) and 4) will require special detection.

+    case HttpPipelinedConnection::OLD_HTTP_VERSION:
+      // TODO(simonjam): I'd like to know if this ever happens after a HTTP/1.1.
+      // What's the best way to track that? If it does happen, I'd like to know
+      // which site, so I can debug it.

[mmenke, 2011/11/17 22:25:37]

I'm no expert, but wouldn't surprise me if it did.  Could see completely
different modules handling requests for different files.  One could be
responsible for serving chunked-encoded streaming videos, and another for static
HTML files, for example.  If they generate the entire response themselves, they
could well return different versions in the headers.

[James Simonsen, 2011/11/18 00:03:56]

That's a good example. I guess I'll just take out the comment then. It'd be a
bummer if a site like this broke pipelining, which is why I wanted to see real
examples.

+      capability_ = INCAPABLE;
+      delegate_->OnHostDeterminedCapability(this, INCAPABLE);
+      break;
+
+    case HttpPipelinedConnection::MUST_CLOSE_CONNECTION:
+      break;
+  }
+}
+
+HttpPipelinedHostImpl::PipelineInfo::PipelineInfo()
+  : capacity(1),

[mmenke, 2011/11/17 22:25:37]

nit:  4 space indent.

[James Simonsen, 2011/11/18 00:03:56]

Done. I really need to figure out how to get vim to do that correctly. You catch
these all the time.

+    num_successes(0) {
+}
+
+}  // namespace net