Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6020)

Unified Diff: chrome/browser/sync/syncable/directory_manager.cc

Issue 8586014: [Sync] Replace uses of ObserverListThreadSafe with WeakHandles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/syncable/directory_manager.h ('k') | chrome/browser/sync/syncable/syncable.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/syncable/directory_manager.cc
diff --git a/chrome/browser/sync/syncable/directory_manager.cc b/chrome/browser/sync/syncable/directory_manager.cc
index b98aacbd3d7c7a237d908bc6c7a107c2c63fc9df..c207b3c52c35859bb68a4687d2a1d7f62a6dfee3 100644
--- a/chrome/browser/sync/syncable/directory_manager.cc
+++ b/chrome/browser/sync/syncable/directory_manager.cc
@@ -42,19 +42,26 @@ DirectoryManager::~DirectoryManager() {
<< "Dir " << managed_directory_->name() << " not closed!";
}
-bool DirectoryManager::Open(const std::string& name,
- DirectoryChangeDelegate* delegate) {
+bool DirectoryManager::Open(
+ const std::string& name,
+ DirectoryChangeDelegate* delegate,
+ const browser_sync::WeakHandle<TransactionObserver>&
+ transaction_observer) {
bool was_open = false;
const DirOpenResult result =
- OpenImpl(name, GetSyncDataDatabasePath(), delegate, &was_open);
+ OpenImpl(name, GetSyncDataDatabasePath(), delegate,
+ transaction_observer, &was_open);
return syncable::OPENED == result;
}
// Opens a directory. Returns false on error.
-DirOpenResult DirectoryManager::OpenImpl(const std::string& name,
- const FilePath& path,
- DirectoryChangeDelegate* delegate,
- bool* was_open) {
+DirOpenResult DirectoryManager::OpenImpl(
+ const std::string& name,
+ const FilePath& path,
+ DirectoryChangeDelegate* delegate,
+ const browser_sync::WeakHandle<TransactionObserver>&
+ transaction_observer,
+ bool* was_open) {
bool opened = false;
{
base::AutoLock lock(lock_);
@@ -72,7 +79,8 @@ DirOpenResult DirectoryManager::OpenImpl(const std::string& name,
// Otherwise, open it.
scoped_ptr<Directory> dir(new Directory);
- const DirOpenResult result = dir->Open(path, name, delegate);
+ const DirOpenResult result =
+ dir->Open(path, name, delegate, transaction_observer);
if (syncable::OPENED == result) {
base::AutoLock lock(lock_);
managed_directory_ = dir.release();
« no previous file with comments | « chrome/browser/sync/syncable/directory_manager.h ('k') | chrome/browser/sync/syncable/syncable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698