Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1746)

Unified Diff: chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc

Issue 8586014: [Sync] Replace uses of ObserverListThreadSafe with WeakHandles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc
diff --git a/chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc b/chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc
index 2dc621a52aa5a349cb36042aa5e167d847e5258a..d401742e20633bb9279207b299d73f0120a68966 100644
--- a/chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc
+++ b/chrome/browser/sync/notifier/non_blocking_invalidation_notifier_unittest.cc
@@ -66,18 +66,29 @@ class NonBlockingInvalidationNotifierTest : public testing::Test {
};
TEST_F(NonBlockingInvalidationNotifierTest, Basic) {
- syncable::ModelTypeSet types;
- types.insert(syncable::BOOKMARKS);
- types.insert(syncable::AUTOFILL);
+ InSequence dummy;
+
+ syncable::ModelTypePayloadMap type_payloads;
+ type_payloads[syncable::PREFERENCES] = "payload";
+ type_payloads[syncable::BOOKMARKS] = "";
+ type_payloads[syncable::AUTOFILL] = "";
+
+ EXPECT_CALL(mock_observer_, OnNotificationStateChange(true));
+ EXPECT_CALL(mock_observer_, StoreState("new_fake_state"));
+ EXPECT_CALL(mock_observer_, OnIncomingNotification(type_payloads));
+ EXPECT_CALL(mock_observer_, OnNotificationStateChange(false));
- invalidation_notifier_->SetUniqueId("fake_id");
invalidation_notifier_->SetState("fake_state");
+ invalidation_notifier_->SetUniqueId("fake_id");
invalidation_notifier_->UpdateCredentials("foo@bar.com", "fake_token");
- invalidation_notifier_->UpdateEnabledTypes(types);
-}
-// TODO(akalin): Add synchronous operations for testing to
-// NonBlockingInvalidationNotifierTest and use that to test it.
+ invalidation_notifier_->OnNotificationStateChange(true);
+ invalidation_notifier_->StoreState("new_fake_state");
+ invalidation_notifier_->OnIncomingNotification(type_payloads);
+ invalidation_notifier_->OnNotificationStateChange(false);
+
+ ui_loop_.RunAllPending();
+}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698