Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: chrome/browser/sync/js/js_mutation_event_observer.h

Issue 8586014: [Sync] Replace uses of ObserverListThreadSafe with WeakHandles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_JS_JS_MUTATION_EVENT_OBSERVER_H_ 5 #ifndef CHROME_BROWSER_SYNC_JS_JS_MUTATION_EVENT_OBSERVER_H_
6 #define CHROME_BROWSER_SYNC_JS_JS_MUTATION_EVENT_OBSERVER_H_ 6 #define CHROME_BROWSER_SYNC_JS_JS_MUTATION_EVENT_OBSERVER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/compiler_specific.h" 12 #include "base/compiler_specific.h"
13 #include "base/memory/weak_ptr.h"
13 #include "base/threading/non_thread_safe.h" 14 #include "base/threading/non_thread_safe.h"
14 #include "chrome/browser/sync/internal_api/sync_manager.h" 15 #include "chrome/browser/sync/internal_api/sync_manager.h"
15 #include "chrome/browser/sync/syncable/transaction_observer.h" 16 #include "chrome/browser/sync/syncable/transaction_observer.h"
16 #include "chrome/browser/sync/util/weak_handle.h" 17 #include "chrome/browser/sync/util/weak_handle.h"
17 18
18 namespace tracked_objects { 19 namespace tracked_objects {
19 class Location; 20 class Location;
20 } // namespace tracked_objects 21 } // namespace tracked_objects
21 22
22 namespace browser_sync { 23 namespace browser_sync {
23 24
24 class JsEventDetails; 25 class JsEventDetails;
25 class JsEventHandler; 26 class JsEventHandler;
26 27
27 // Observes all change- and transaction-related events and routes a 28 // Observes all change- and transaction-related events and routes a
28 // summarized version to a JsEventHandler. 29 // summarized version to a JsEventHandler.
29 class JsMutationEventObserver 30 class JsMutationEventObserver
30 : public sync_api::SyncManager::ChangeObserver, 31 : public sync_api::SyncManager::ChangeObserver,
31 public syncable::TransactionObserver { 32 public syncable::TransactionObserver {
32 public: 33 public:
33 JsMutationEventObserver(); 34 JsMutationEventObserver();
34 35
35 virtual ~JsMutationEventObserver(); 36 virtual ~JsMutationEventObserver();
36 37
38 base::WeakPtr<JsMutationEventObserver> AsWeakPtr();
39
40 void InvalidateWeakPtrs();
41
37 void SetJsEventHandler(const WeakHandle<JsEventHandler>& event_handler); 42 void SetJsEventHandler(const WeakHandle<JsEventHandler>& event_handler);
38 43
39 // sync_api::SyncManager::ChangeObserver implementation. 44 // sync_api::SyncManager::ChangeObserver implementation.
40 virtual void OnChangesApplied( 45 virtual void OnChangesApplied(
41 syncable::ModelType model_type, 46 syncable::ModelType model_type,
42 int64 write_transaction_id, 47 int64 write_transaction_id,
43 const sync_api::ImmutableChangeRecordList& changes) OVERRIDE; 48 const sync_api::ImmutableChangeRecordList& changes) OVERRIDE;
44 virtual void OnChangesComplete(syncable::ModelType model_type) OVERRIDE; 49 virtual void OnChangesComplete(syncable::ModelType model_type) OVERRIDE;
45 50
46 // syncable::TransactionObserver implementation. 51 // syncable::TransactionObserver implementation.
47 virtual void OnTransactionStart( 52 virtual void OnTransactionStart(
48 const tracked_objects::Location& location, 53 const tracked_objects::Location& location,
49 const syncable::WriterTag& writer) OVERRIDE; 54 const syncable::WriterTag& writer) OVERRIDE;
50 virtual void OnTransactionWrite( 55 virtual void OnTransactionWrite(
51 const syncable::ImmutableWriteTransactionInfo& write_transaction_info, 56 const syncable::ImmutableWriteTransactionInfo& write_transaction_info,
52 const syncable::ModelTypeBitSet& models_with_changes) OVERRIDE; 57 const syncable::ModelTypeBitSet& models_with_changes) OVERRIDE;
53 virtual void OnTransactionEnd( 58 virtual void OnTransactionEnd(
54 const tracked_objects::Location& location, 59 const tracked_objects::Location& location,
55 const syncable::WriterTag& writer) OVERRIDE; 60 const syncable::WriterTag& writer) OVERRIDE;
56 61
57 private: 62 private:
58 base::NonThreadSafe non_thread_safe_; 63 base::NonThreadSafe non_thread_safe_;
64 base::WeakPtrFactory<JsMutationEventObserver> weak_ptr_factory_;
59 WeakHandle<JsEventHandler> event_handler_; 65 WeakHandle<JsEventHandler> event_handler_;
60 66
61 void HandleJsEvent( 67 void HandleJsEvent(
62 const tracked_objects::Location& from_here, 68 const tracked_objects::Location& from_here,
63 const std::string& name, const JsEventDetails& details); 69 const std::string& name, const JsEventDetails& details);
64 70
65 DISALLOW_COPY_AND_ASSIGN(JsMutationEventObserver); 71 DISALLOW_COPY_AND_ASSIGN(JsMutationEventObserver);
66 }; 72 };
67 73
68 } // namespace browser_sync 74 } // namespace browser_sync
69 75
70 #endif // CHROME_BROWSER_SYNC_JS_JS_MUTATION_EVENT_OBSERVER_H_ 76 #endif // CHROME_BROWSER_SYNC_JS_JS_MUTATION_EVENT_OBSERVER_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/internal_api/syncapi_unittest.cc ('k') | chrome/browser/sync/js/js_mutation_event_observer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698