Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: chrome/browser/sync/test/engine/test_directory_setter_upper.cc

Issue 8586014: [Sync] Replace uses of ObserverListThreadSafe with WeakHandles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/test/engine/test_directory_setter_upper.h" 5 #include "chrome/browser/sync/test/engine/test_directory_setter_upper.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/string_util.h" 10 #include "base/string_util.h"
11 #include "chrome/browser/sync/syncable/directory_manager.h" 11 #include "chrome/browser/sync/syncable/directory_manager.h"
12 #include "chrome/browser/sync/syncable/syncable.h" 12 #include "chrome/browser/sync/syncable/syncable.h"
13 #include "chrome/browser/sync/test/null_transaction_observer.h"
13 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
14 15
15 using syncable::DirectoryManager; 16 using syncable::DirectoryManager;
17 using syncable::NullTransactionObserver;
16 using syncable::ReadTransaction; 18 using syncable::ReadTransaction;
17 using syncable::ScopedDirLookup; 19 using syncable::ScopedDirLookup;
18 20
19 namespace browser_sync { 21 namespace browser_sync {
20 22
21 TestDirectorySetterUpper::TestDirectorySetterUpper() : name_("Test") {} 23 TestDirectorySetterUpper::TestDirectorySetterUpper() : name_("Test") {}
22 TestDirectorySetterUpper::TestDirectorySetterUpper(const std::string& name) 24 TestDirectorySetterUpper::TestDirectorySetterUpper(const std::string& name)
23 : name_(name) {} 25 : name_(name) {}
24 26
25 TestDirectorySetterUpper::~TestDirectorySetterUpper() {} 27 TestDirectorySetterUpper::~TestDirectorySetterUpper() {}
26 28
27 void TestDirectorySetterUpper::Init() { 29 void TestDirectorySetterUpper::Init() {
28 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); 30 ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
29 reset_directory_manager(new DirectoryManager(temp_dir_.path())); 31 reset_directory_manager(new DirectoryManager(temp_dir_.path()));
30 // There shouldn't be any existing database in the newly-created 32 // There shouldn't be any existing database in the newly-created
31 // temp dir. 33 // temp dir.
32 ASSERT_FALSE(file_util::PathExists(manager_->GetSyncDataDatabasePath())); 34 ASSERT_FALSE(file_util::PathExists(manager_->GetSyncDataDatabasePath()));
33 } 35 }
34 36
35 void TestDirectorySetterUpper::reset_directory_manager(DirectoryManager* d) { 37 void TestDirectorySetterUpper::reset_directory_manager(DirectoryManager* d) {
36 manager_.reset(d); 38 manager_.reset(d);
37 } 39 }
38 40
39 void TestDirectorySetterUpper::SetUp() { 41 void TestDirectorySetterUpper::SetUp() {
40 Init(); 42 Init();
41 ASSERT_TRUE(manager()->Open(name(), &delegate_)); 43 ASSERT_TRUE(manager()->Open(name(), &delegate_, NullTransactionObserver()));
42 } 44 }
43 45
44 void TestDirectorySetterUpper::TearDown() { 46 void TestDirectorySetterUpper::TearDown() {
45 if (!manager()) 47 if (!manager())
46 return; 48 return;
47 49
48 { 50 {
49 // A small scope so we don't have the dir open when we close it and reset 51 // A small scope so we don't have the dir open when we close it and reset
50 // the DirectoryManager below. 52 // the DirectoryManager below.
51 ScopedDirLookup dir(manager(), name()); 53 ScopedDirLookup dir(manager(), name());
(...skipping 21 matching lines...) Expand all
73 ReadTransaction trans(FROM_HERE, dir); 75 ReadTransaction trans(FROM_HERE, dir);
74 dir->CheckTreeInvariants(&trans, true); 76 dir->CheckTreeInvariants(&trans, true);
75 } 77 }
76 } 78 }
77 79
78 void ManuallyOpenedTestDirectorySetterUpper::SetUp() { 80 void ManuallyOpenedTestDirectorySetterUpper::SetUp() {
79 Init(); 81 Init();
80 } 82 }
81 83
82 void ManuallyOpenedTestDirectorySetterUpper::Open() { 84 void ManuallyOpenedTestDirectorySetterUpper::Open() {
83 ASSERT_TRUE(manager()->Open(name(), &delegate_)); 85 ASSERT_TRUE(
86 manager()->Open(name(), &delegate_, NullTransactionObserver()));
84 was_opened_ = true; 87 was_opened_ = true;
85 } 88 }
86 89
87 void ManuallyOpenedTestDirectorySetterUpper::TearDown() { 90 void ManuallyOpenedTestDirectorySetterUpper::TearDown() {
88 if (was_opened_) { 91 if (was_opened_) {
89 TestDirectorySetterUpper::TearDown(); 92 TestDirectorySetterUpper::TearDown();
90 } 93 }
91 } 94 }
92 95
93 TriggeredOpenTestDirectorySetterUpper::TriggeredOpenTestDirectorySetterUpper( 96 TriggeredOpenTestDirectorySetterUpper::TriggeredOpenTestDirectorySetterUpper(
(...skipping 10 matching lines...) Expand all
104 manager()->GetOpenDirectories(&names); 107 manager()->GetOpenDirectories(&names);
105 if (!names.empty()) { 108 if (!names.empty()) {
106 ASSERT_EQ(1U, names.size()); 109 ASSERT_EQ(1U, names.size());
107 ASSERT_EQ(name(), names[0]); 110 ASSERT_EQ(name(), names[0]);
108 TestDirectorySetterUpper::TearDown(); 111 TestDirectorySetterUpper::TearDown();
109 } 112 }
110 } 113 }
111 114
112 MockDirectorySetterUpper::MockDirectory::MockDirectory( 115 MockDirectorySetterUpper::MockDirectory::MockDirectory(
113 const std::string& name) { 116 const std::string& name) {
114 InitKernel(name, &delegate_); 117 InitKernelForTest(name, &delegate_, NullTransactionObserver());
115 } 118 }
116 119
117 MockDirectorySetterUpper::MockDirectory::~MockDirectory() {} 120 MockDirectorySetterUpper::MockDirectory::~MockDirectory() {}
118 121
119 MockDirectorySetterUpper::Manager::Manager( 122 MockDirectorySetterUpper::Manager::Manager(
120 const FilePath& root_path, syncable::Directory* dir) : 123 const FilePath& root_path, syncable::Directory* dir) :
121 syncable::DirectoryManager(root_path) { 124 syncable::DirectoryManager(root_path) {
122 managed_directory_ = dir; 125 managed_directory_ = dir;
123 } 126 }
124 127
125 MockDirectorySetterUpper::MockDirectorySetterUpper() 128 MockDirectorySetterUpper::MockDirectorySetterUpper()
126 : directory_(new MockDirectory(name())) { 129 : directory_(new MockDirectory(name())) {
127 } 130 }
128 131
129 MockDirectorySetterUpper::~MockDirectorySetterUpper() {} 132 MockDirectorySetterUpper::~MockDirectorySetterUpper() {}
130 133
131 void MockDirectorySetterUpper::SetUp() { 134 void MockDirectorySetterUpper::SetUp() {
132 reset_directory_manager(new Manager(FilePath(), directory_.get())); 135 reset_directory_manager(new Manager(FilePath(), directory_.get()));
133 } 136 }
134 137
135 void MockDirectorySetterUpper::TearDown() { 138 void MockDirectorySetterUpper::TearDown() {
136 // Nothing to do here. 139 // Nothing to do here.
137 } 140 }
138 141
139 } // namespace browser_sync 142 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698