Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: chrome/browser/sync/js/js_mutation_event_observer.cc

Issue 8586014: [Sync] Replace uses of ObserverListThreadSafe with WeakHandles (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync/js/js_mutation_event_observer.h" 5 #include "chrome/browser/sync/js/js_mutation_event_observer.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/location.h" 9 #include "base/location.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
11 #include "base/string_number_conversions.h" 11 #include "base/string_number_conversions.h"
12 #include "base/values.h" 12 #include "base/values.h"
13 #include "chrome/browser/sync/js/js_event_details.h" 13 #include "chrome/browser/sync/js/js_event_details.h"
14 #include "chrome/browser/sync/js/js_event_handler.h" 14 #include "chrome/browser/sync/js/js_event_handler.h"
15 15
16 namespace browser_sync { 16 namespace browser_sync {
17 17
18 JsMutationEventObserver::JsMutationEventObserver() {} 18 JsMutationEventObserver::JsMutationEventObserver()
19 : weak_ptr_factory_(ALLOW_THIS_IN_INITIALIZER_LIST(this)) {}
19 20
20 JsMutationEventObserver::~JsMutationEventObserver() { 21 JsMutationEventObserver::~JsMutationEventObserver() {
21 DCHECK(non_thread_safe_.CalledOnValidThread()); 22 DCHECK(non_thread_safe_.CalledOnValidThread());
22 } 23 }
23 24
25 base::WeakPtr<JsMutationEventObserver> JsMutationEventObserver::AsWeakPtr() {
26 return weak_ptr_factory_.GetWeakPtr();
27 }
28
29 void JsMutationEventObserver::InvalidateWeakPtrs() {
30 weak_ptr_factory_.InvalidateWeakPtrs();
31 }
32
24 void JsMutationEventObserver::SetJsEventHandler( 33 void JsMutationEventObserver::SetJsEventHandler(
25 const WeakHandle<JsEventHandler>& event_handler) { 34 const WeakHandle<JsEventHandler>& event_handler) {
26 event_handler_ = event_handler; 35 event_handler_ = event_handler;
27 } 36 }
28 37
29 void JsMutationEventObserver::OnTransactionStart( 38 void JsMutationEventObserver::OnTransactionStart(
30 const tracked_objects::Location& location, 39 const tracked_objects::Location& location,
31 const syncable::WriterTag& writer) { 40 const syncable::WriterTag& writer) {
32 DCHECK(non_thread_safe_.CalledOnValidThread()); 41 DCHECK(non_thread_safe_.CalledOnValidThread());
33 if (!event_handler_.IsInitialized()) { 42 if (!event_handler_.IsInitialized()) {
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 const std::string& name, const JsEventDetails& details) { 129 const std::string& name, const JsEventDetails& details) {
121 if (!event_handler_.IsInitialized()) { 130 if (!event_handler_.IsInitialized()) {
122 NOTREACHED(); 131 NOTREACHED();
123 return; 132 return;
124 } 133 }
125 event_handler_.Call(from_here, 134 event_handler_.Call(from_here,
126 &JsEventHandler::HandleJsEvent, name, details); 135 &JsEventHandler::HandleJsEvent, name, details);
127 } 136 }
128 137
129 } // namespace browser_sync 138 } // namespace browser_sync
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698