[Sync] Replace uses of ObserverListThreadSafe with WeakHandles

chrome/browser/sync/engine/syncer_proto_util_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/engine/syncer_proto_util.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/message_loop.h"
 #include "chrome/browser/sync/engine/syncproto.h"
 #include "chrome/browser/sync/syncable/blob.h"
 #include "chrome/browser/sync/syncable/directory_manager.h"
 #include "chrome/browser/sync/syncable/syncable.h"
 #include "chrome/browser/sync/test/engine/mock_connection_manager.h"
 #include "chrome/browser/sync/test/engine/test_directory_setter_upper.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 using syncable::Blob;
@@ skipping 109 matching lines @@
  public:
   virtual void SetUp() {
     setter_upper_.SetUp();
   }
 
   virtual void TearDown() {
     setter_upper_.TearDown();
   }
 
  protected:
+  MessageLoop message_loop_;

[Nicolas Zea, 2011/11/17 21:35:45]

What is this used by?

[akalin, 2011/11/18 00:04:32]

Any test that opens a Transaction uses a WeakHandle, which needs to have been
constructed on a thread with a loop.  We didn't have this problem when we used
OLTS because it had a hack to work around this. (This is mentioned in the CL
description.)

   browser_sync::TestDirectorySetterUpper setter_upper_;
 };
 
 TEST_F(SyncerProtoUtilTest, VerifyResponseBirthday) {
   ScopedDirLookup lookup(setter_upper_.manager(), setter_upper_.name());
   ASSERT_TRUE(lookup.good());
 
   // Both sides empty
   EXPECT_TRUE(lookup->store_birthday().empty());
   ClientToServerResponse response;
@@ skipping 82 matching lines @@
   dcm.set_send_error(false);
   EXPECT_TRUE(SyncerProtoUtil::PostAndProcessHeaders(&dcm, NULL,
       msg, &response));
 
   dcm.set_access_denied(true);
   EXPECT_FALSE(SyncerProtoUtil::PostAndProcessHeaders(&dcm, NULL,
       msg, &response));
 }
 
 }  // namespace browser_sync