Added 4 new pyauto tests.

functional/chromeos_wifi_functional.py

 #!/usr/bin/python

[dennis_jeffrey, 2011/11/17 02:38:25]

Please modify the description of this CL so that it is more specific, maybe
something like this:

"Adding 4 new pyauto wifi tests for ChromeOS."

[deepakg, 2011/11/17 23:21:15]

Done.

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 
 import pyauto_functional
 import chromeos_network  # pyauto_functional must come before chromeos_network
 import pyauto_utils
 
 
 class ChromeosWifiFunctional(chromeos_network.PyNetworkUITest):
   """Tests for ChromeOS wifi functionality.
 
   These tests should be run within vacinity of the power strip where the wifi
   routers are attached.
   """
 
-  def _LoginDevice(self):
+  def _LoginDevice(self, test_account='test_google_account'):
     """Logs into the device and cleans up flimflam profile."""

[dennis_jeffrey, 2011/11/17 02:38:25]

Add an "Args:" section to this docstring that describes the new input parameter.

[deepakg, 2011/11/17 23:21:15]

Done.

     if not self.GetLoginInfo()['is_logged_in']:
-      credentials = self.GetPrivateInfo()['test_google_account']
+      credentials = self.GetPrivateInfo()[test_account]
       self.Login(credentials['username'], credentials['password'])
       login_info = self.GetLoginInfo()
       self.assertTrue(login_info['is_logged_in'], msg='Login failed.')
 
     ff_dir = '/home/chronos/user/flimflam'
     self.assertTrue(os.path.isdir(ff_dir), 'User is logged in but user '
                     'flimflam profile is not present.')
 
     # Clean up the items in the flimflam profile directory.
     for item in os.listdir(ff_dir):
@@ skipping 55 matching lines @@
     error = self.ConnectToWifiRouter(router_name, shared=False)
     self.assertFalse(error, 'Failed to connect to wifi network %s. '
                             'Reason: %s.' % (router['ssid'], error))
     service_path = self.GetServicePath(router['ssid'])
     self.assertTrue(service_path in self.GetNetworkInfo()['remembered_wifi'],
                     'Connected wifi was not added to the remembered list.')
     self.ForgetWifiNetwork(service_path)
     self.assertFalse(service_path in self.GetNetworkInfo()['remembered_wifi'],
                      'Connected wifi was not removed from the remembered list.')
 
+  def testConnectToNonSharedOpenNetwork(self):
+    """Can connect to a shared open network and are connected to this

[dennis_jeffrey, 2011/11/17 02:38:25]

'shared' --> 'non-shared'

[deepakg, 2011/11/17 23:21:15]

Done.

+    even after logout.

[dennis_jeffrey, 2011/11/17 02:38:25]

The first line of the docstring should be a 1-line summary that fits on a single
line.  If you have any more details to add, then you should add 1 blank line,
followed by the rest of the details.

[deepakg, 2011/11/17 23:21:15]

Done.

+    """
+    router_name = 'Trendnet_639gr_4'
+    self._LoginDevice()
+    router = self._SetupRouter(router_name)
+    error = self.ConnectToWifiRouter(router_name, shared=False)
+    self.assertFalse(error, msg='Failed to connect to wifi network %s. '
+                            'Reason: %s.' % (router['ssid'], error))
+    service_path = self.GetServicePath(router['ssid'])
+    self.assertTrue(service_path in self.GetNetworkInfo()['remembered_wifi'],
+                    msg='Open wifi is not remembered for the current user.')
+    self.Logout()
+    for path in self.GetNetworkInfo()['wifi_networks']:
+      if path == service_path:

[dennis_jeffrey, 2011/11/17 02:38:25]

If this condition is never true, the test will still pass.  Should we fail the
test after the "for" loop, so that the test fails if this condition is never
true?

[deepakg, 2011/11/17 23:21:15]

Done.

+        self.assertTrue(self.GetNetworkInfo()['wifi_networks'][path]['status']
+                         == 'Association', msg='We are not connected to the'
+                        ' shared open network after logout.')

[dennis_jeffrey, 2011/11/17 02:38:25]

I think it would be a little cleaner to indent like this:

self.assertTrue(
    self.GetNetworkInfo()['wifi_networks'][path]['status'] == 'Association'
    msg='We are not connected to the non-shared open network after logout.')

[dennis_jeffrey, 2011/11/17 02:38:25]

'shared' --> 'non-shared'

[deepakg, 2011/11/17 23:21:15]

This will push the characters beyond the 80 character limit.

[deepakg, 2011/11/17 23:21:15]

Done.

+        break;
+
+  def testConnectToSharedOpenNetwork(self):
+    """Can connect to a shared open network and it is in the remembered
+    network list for all the users.

[dennis_jeffrey, 2011/11/17 02:38:25]

The first line of the docstring should fit onto a single line.

[deepakg, 2011/11/17 23:21:15]

Done.

+    """
+    router_name = 'Trendnet_639gr_4'
+    self._LoginDevice()
+    router = self._SetupRouter(router_name)
+    error = self.ConnectToWifiRouter(router_name, shared=True)
+    self.assertFalse(error, msg='Failed to connect to wifi network %s. '
+                            'Reason: %s.' % (router['ssid'], error))
+    service_path = self.GetServicePath(router['ssid'])
+    self.assertTrue(service_path in self.GetNetworkInfo()['remembered_wifi'],
+                    msg='Open Wifi is not remembered for the current user.')
+    self.Logout()
+    self._LoginDevice(test_account='test_google_account_2')
+    self.assertTrue(service_path in self.NetworkScan()['remembered_wifi'],
+                    msg='Open network is not shared with other users.')
+
+  def testConnectToSharedHiddenNetwork(self):
+    """Can connect to shared hidden network and verify that its shared."""

[dennis_jeffrey, 2011/11/17 02:38:25]

'its' --> 'it's'

[deepakg, 2011/11/17 23:21:15]

Done.

+    router_name = "Netgear_WGR614"
+    self._LoginDevice()
+    router = self._SetupRouter(router_name)
+    error = self.ConnectToWifiRouter(router_name)
+    self.assertFalse(error, msg='Failed to connect to hidden network %s. '
+                            'Reason: %s.' % (router['ssid'], error))
+    service_path = self.GetServicePath(router['ssid'])
+    self.assertTrue(service_path in self.NetworkScan()['remembered_wifi'],
+                    msg='Hidden network is not added to the remembered list.')
+    self.Logout()
+    self._LoginDevice(test_account='test_google_account_2')
+    self.assertTrue(service_path in self.NetworkScan()['remembered_wifi'],
+                    msg='Shared Hidden network is not in other users '

[dennis_jeffrey, 2011/11/17 02:38:25]

'users' --> 'user's'

[deepakg, 2011/11/17 23:21:15]

Done.

+                    'remembered list.')
+
+  def testConnectToNonSharedHiddenNetwork(self):
+    """Can connect to a non-shared hidden network and
+     verify that its not shared.

[dennis_jeffrey, 2011/11/17 02:38:25]

'its' --> 'it's'

[dennis_jeffrey, 2011/11/17 02:38:25]

The first line of the docstring should fit onto a single line

[deepakg, 2011/11/17 23:21:15]

Done.

[deepakg, 2011/11/17 23:21:15]

Done.

+    """   
+    router_name = "Linksys_WRT54GL"
+    self._LoginDevice()
+    router = self._SetupRouter(router_name)
+    error = self.ConnectToWifiRouter(router_name, shared=False)
+    self.assertFalse(error, msg='Failed to connect to hidden network %s. '
+                            'Reason: %s.' % (router['ssid'], error))
+    service_path = self.GetServicePath(router['ssid'])
+    self.assertTrue(service_path in self.NetworkScan()['remembered_wifi'],
+                    msg='Hidden network is not added to the remembered list.')
+    self.Logout()
+    self._LoginDevice(test_account='test_google_account_2')
+    self.assertFalse(service_path in self.NetworkScan()['remembered_wifi'],
+                     msg='Non-shared Hidden network is shared.')
+
 
 if __name__ == '__main__':
   pyauto_functional.Main()