Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: chrome/browser/safe_browsing/download_protection_service.h

Issue 8586011: - Flip the flag for improved SafeBrowsing downoad protection. (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: Address Matt's comment. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/download_protection_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/download_protection_service.h
diff --git a/chrome/browser/safe_browsing/download_protection_service.h b/chrome/browser/safe_browsing/download_protection_service.h
index 60af4a27770f2968374696256362ace1893f8743..0918e96052bd59e4cbcb729d4c6f54e8f02f14c3 100644
--- a/chrome/browser/safe_browsing/download_protection_service.h
+++ b/chrome/browser/safe_browsing/download_protection_service.h
@@ -96,6 +96,11 @@ class DownloadProtectionService {
return enabled_;
}
+ // Returns the timeout that is used by CheckClientDownload().
+ int64 download_request_timeout_ms() const {
+ return download_request_timeout_ms_;
+ }
+
protected:
// Enum to keep track why a particular download verdict was chosen.
// This is used to keep some stats around.
@@ -127,6 +132,8 @@ class DownloadProtectionService {
CheckClientDownloadSuccess);
FRIEND_TEST_ALL_PREFIXES(DownloadProtectionServiceTest,
CheckClientDownloadFetchFailed);
+ FRIEND_TEST_ALL_PREFIXES(DownloadProtectionServiceTest,
+ TestDownloadRequestTimeout);
static const char kDownloadRequestUrl[];
@@ -159,6 +166,8 @@ class DownloadProtectionService {
// SignatureUtil object, may be overridden for testing.
scoped_refptr<SignatureUtil> signature_util_;
+ int64 download_request_timeout_ms_;
+
DISALLOW_COPY_AND_ASSIGN(DownloadProtectionService);
};
} // namespace safe_browsing
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/download_protection_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698