Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8916)

Unified Diff: chrome/test/data/webui/async_gen.js

Issue 8586009: Allow WebUI Tests to use preLoad in HtmlDialogUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/webui/async_gen.cc ('k') | chrome/test/data/webui/async_gen-inl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/async_gen.js
diff --git a/chrome/test/data/webui/async_gen.js b/chrome/test/data/webui/async_gen.js
index 13929b82d2a0ca63a22122a41364d44a86cb3613..8b8078f7a842b26454d783a260440116394f5eb3 100644
--- a/chrome/test/data/webui/async_gen.js
+++ b/chrome/test/data/webui/async_gen.js
@@ -23,7 +23,7 @@ WebUIBrowserAsyncGenTest.prototype = {
expectFalse(this.tornDown);
expectFalse(this.running);
this.tornDown = true;
- chrome.send('tornDown');
+ chrome.send('tearDown');
testing.Test.prototype.tearDown.call(this);
},
@@ -46,18 +46,8 @@ WebUIBrowserAsyncGenTest.prototype = {
running: false,
};
-// Include the bulk of c++ code.
-GEN('#include "chrome/test/data/webui/async_gen-inl.h"');
-GEN('');
-
-// Constructors and destructors must be provided in .cc to prevent clang errors.
-GEN('WebUIBrowserAsyncGenTest::WebUIBrowserAsyncGenTest() {}');
-GEN('WebUIBrowserAsyncGenTest::~WebUIBrowserAsyncGenTest() {}');
-GEN('WebUIBrowserAsyncGenTest::AsyncWebUIMessageHandler::');
-GEN(' AsyncWebUIMessageHandler() {}');
-GEN('WebUIBrowserAsyncGenTest::AsyncWebUIMessageHandler::');
-GEN(' ~AsyncWebUIMessageHandler() {}');
-GEN('');
+// Include the c++ test fixture.
+GEN('#include "chrome/test/data/webui/async_gen.h"');
/**
* Will be set to continuation test #1.
« no previous file with comments | « chrome/test/data/webui/async_gen.cc ('k') | chrome/test/data/webui/async_gen-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698