Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/test/base/test_navigation_observer.cc

Issue 8586009: Allow WebUI Tests to use preLoad in HtmlDialogUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add conditional set_preload_ info. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/base/test_navigation_observer.cc
diff --git a/chrome/test/test_navigation_observer.cc b/chrome/test/base/test_navigation_observer.cc
similarity index 91%
rename from chrome/test/test_navigation_observer.cc
rename to chrome/test/base/test_navigation_observer.cc
index 7e0c2f0a2f933b4f718d61bb8919ad3fc2d158cf..08fa6bb44b5ec2a628a1752e2cef680d57045be4 100644
--- a/chrome/test/test_navigation_observer.cc
+++ b/chrome/test/base/test_navigation_observer.cc
@@ -2,8 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/test/test_navigation_observer.h"
+#include "chrome/test/base/test_navigation_observer.h"
+#include "chrome/test/base/js_injection_ready_observer.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/browser/renderer_host/render_view_host_observer.h"
#include "content/public/browser/notification_service.h"
@@ -33,16 +34,9 @@ class TestNavigationObserver::RVHOSendJS : public RenderViewHostObserver {
DISALLOW_COPY_AND_ASSIGN(RVHOSendJS);
};
-TestNavigationObserver::JsInjectionReadyObserver::JsInjectionReadyObserver() {
-}
-
-TestNavigationObserver::JsInjectionReadyObserver::~JsInjectionReadyObserver() {
-}
-
TestNavigationObserver::TestNavigationObserver(
const content::NotificationSource& source,
- TestNavigationObserver::JsInjectionReadyObserver*
- js_injection_ready_observer,
+ JsInjectionReadyObserver* js_injection_ready_observer,
int number_of_navigations)
: navigation_started_(false),
navigations_completed_(0),
@@ -70,7 +64,7 @@ void TestNavigationObserver::WaitForObservation() {
}
TestNavigationObserver::TestNavigationObserver(
- TestNavigationObserver::JsInjectionReadyObserver*
+ JsInjectionReadyObserver*
js_injection_ready_observer,
int number_of_navigations)
: navigation_started_(false),

Powered by Google App Engine
This is Rietveld 408576698