chrome/test/base/js_injection_ready_observer.h - Issue 8586009: Allow WebUI Tests to use preLoad in HtmlDialogUI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/base/js_injection_ready_observer.h

Issue 8586009: Allow WebUI Tests to use preLoad in HtmlDialogUI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address more comments from James. Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_TEST_BASE_JS_INJECTION_READY_OBSERVER_H_

	6 #define CHROME_TEST_BASE_JS_INJECTION_READY_OBSERVER_H_

	7 #pragma once

	8

	9 class RenderViewHost;

	10

	11 // Interface to notify when JavaScript injection is possible.

	12 class JsInjectionReadyObserver {

	13 public:

	14 // Called to indicate page entry committed and ready for JavaScript

	15 // injection. \|render_view_host\| may be used to route injection messages to

	16 // the appropriate RenderView.

	17 virtual void OnJsInjectionReady(RenderViewHost* render_view_host) = 0;

	18

	19 protected:

	20 JsInjectionReadyObserver();
	James Hawkins 2011/11/29 18:20:54 Remove the constructor. We don't add constructors Remove the constructor. We don't add constructors for interfaces. Sheridan Rawlins 2011/11/29 23:56:49 Done. Show quoted text On 2011/11/29 18:20:54, James Hawkins wrote: > Remove the constructor. We don't add constructors for interfaces. Done.
	21 virtual ~JsInjectionReadyObserver();

	22 };

	23

	24 #endif // CHROME_TEST_BASE_JS_INJECTION_READY_OBSERVER_H_

OLD	NEW