Issue 8585043: chromeos: Fix a clang build error in CandidateWindowView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8585043: chromeos: Fix a clang build error in CandidateWindowView. (Closed)

Created:
9 years, 1 month ago by satorux1

Modified:
9 years, 1 month ago

Reviewers:
oshima

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Fix a clang build error in CandidateWindowView. Clang doesn't like the destructor to be inlined in .h file. ./chrome/browser/chromeos/input_method/candidate_window_view.h:32:3: error: [chromium-style] Complex destructor has an inline body. The error was caused by crrev.com/110492 TEST=chrome builds BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110563

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	chrome/browser/chromeos/input_method/candidate_window.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/input_method/candidate_window_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

satorux1

Thanks. nona@, please run linux_chromeos_clang try bot next time.

9 years, 1 month ago (2011-11-17 21:23:31 UTC) #2

Seigo Nonaka

9 years, 1 month ago (2011-11-18 01:00:31 UTC) #3

On 2011/11/17 21:23:31, satorux1 wrote:
> Thanks.
> 
> nona@, please run linux_chromeos_clang try bot next time.

Oops! Thank you for your kind fix, and I will keep in mind, sorry.

Expand Messages | Collapse Messages