Fix DownloadTests and change cros/aura to use shelf

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index ea340c7fdc3d8c84b2eb77978292fc5c83446388..b0b756f4175388ea0f3c068abb2bb441ba4096c4 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -184,8 +184,10 @@
 #if defined(OS_CHROMEOS)
 #include "chrome/browser/chromeos/boot_times_loader.h"
 #include "chrome/browser/ui/webui/active_downloads_ui.h"
-#else
-#include "chrome/browser/download/download_shelf.h"
+#endif
+
+#if !defined(OS_CHROMEOS) || defined(USE_AURA)
+#include "chrome/browser/ui/views/download/download_shelf_view.h"

[Ben Goodger (Google), 2011/11/17 22:28:37]

We can't include views code here, it's a layering violation. What was wrong with
download_shelf.h?

[DaveMoore, 2011/11/18 18:17:35]

It was a copy / paste mistake.

On 2011/11/17 22:28:37, Ben Goodger (Google) wrote:

 #endif
 
 #if defined(FILE_MANAGER_EXTENSION)
@@ -1437,7 +1439,7 @@ bool Browser::SupportsWindowFeatureImpl(WindowFeature feature,
 
   unsigned int features = FEATURE_INFOBAR | FEATURE_SIDEBAR;
 
-#if !defined(OS_CHROMEOS)
+#if !defined(OS_CHROMEOS) || defined(USE_AURA)
   // Chrome OS opens a FileBrowse pop up instead of using download shelf.
   // So FEATURE_DOWNLOADSHELF is only added for non-chromeos platforms.
   features |= FEATURE_DOWNLOADSHELF;
@@ -3716,7 +3718,7 @@ void Browser::OnStartDownload(TabContents* source, DownloadItem* download) {
     return;
 
   if (DisplayOldDownloadsUI()) {
-#if defined(OS_CHROMEOS)
+#if defined(OS_CHROMEOS) && !defined(USE_AURA)
     // Don't show content browser for extension/theme downloads from gallery.
     ExtensionService* service = profile_->GetExtensionService();
     if (!ChromeDownloadManagerDelegate::IsExtensionDownload(download) ||
@@ -3726,7 +3728,7 @@ void Browser::OnStartDownload(TabContents* source, DownloadItem* download) {
       // Open the Active Downloads ui for chromeos.
       ActiveDownloadsUI::OpenPopup(profile_);
     }
-#elif !defined(USE_AURA)
+#else
     // GetDownloadShelf creates the download shelf if it was not yet created.
     DownloadShelf* shelf = window()->GetDownloadShelf();
     shelf->AddDownload(new DownloadItemModel(download));