Issue 8585040: Fix DownloadTests and change cros/aura to use shelf

Issue 8585040: Fix DownloadTests and change cros/aura to use shelf (Closed)

Created:
9 years, 1 month ago by DaveMoore

Modified:
9 years, 1 month ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays), rdsmith+dwatch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix DownloadTests and change cros/aura to use shelf BUG=103488 TEST=DownloadTests.* browser tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110765 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110770

Patch Set 2 : modified comments #

Patch Set 3 : Review nits #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -213 lines)			Patch
M	chrome/browser/download/download_browsertest.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/download/download_util.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 2	4 chunks	+7 lines, -5 lines	0 comments	Download
A +	chrome/browser/ui/views/download/download_started_animation_views.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/browser/ui/views/download/download_started_animation_win.cc	View		1 chunk	+0 lines, -184 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2	5 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view_layout.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	4 chunks	+9 lines, -10 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

http://codereview.chromium.org/8585040/diff/1/chrome/browser/download/download_util.cc File chrome/browser/download/download_util.cc (right): http://codereview.chromium.org/8585040/diff/1/chrome/browser/download/download_util.cc#newcode520 chrome/browser/download/download_util.cc:520: #if defined(OS_WIN) I wonder if we will want to ...

9 years, 1 month ago (2011-11-17 22:28:36 UTC) #2

DaveMoore

9 years, 1 month ago (2011-11-18 18:17:34 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/8585040/6001

9 years, 1 month ago (2011-11-18 18:38:07 UTC) #5

commit-bot: I haz the power

9 years, 1 month ago (2011-11-18 19:53:02 UTC) #6

Try job failure for 8585040-6001 (retry) on linux_rel for step "ui_tests".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Expand Messages | Collapse Messages