Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 8585038: Add histogram to measure failure reasons for SSL Search (Closed)

Created:
9 years, 1 month ago by agl
Modified:
9 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Visibility:
Public.

Description

Add histogram to measure failure reasons for SSL Search This change adds a histogram that measures the reasons why loads of https://www.google.com fail in the hopes of getting some visibility into the recent SSL search launch. Since the users were navigating to a Google property in any case, and we would have a log of that, this doesn't have any additional privacy impact. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112569

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/browser/renderer_host/resource_dispatcher_host.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
agl
9 years, 1 month ago (2011-11-17 19:29:58 UTC) #1
jar (doing other things)
There is a notable data footprint for this histogram... so we should be wary to ...
9 years, 1 month ago (2011-11-17 20:24:59 UTC) #2
agl
(throwing to Avi for OWNERs LGTM.)
9 years ago (2011-12-01 21:17:40 UTC) #3
Avi (use Gerrit)
owner rubberstamp lgtm
9 years ago (2011-12-01 21:53:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/agl@chromium.org/8585038/1
9 years ago (2011-12-01 22:00:03 UTC) #5
commit-bot: I haz the power
9 years ago (2011-12-01 23:17:06 UTC) #6
Change committed as 112569

Powered by Google App Engine
This is Rietveld 408576698