Issue 8585037: Revert the revert. This change was not the cause of the failures, so relanding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8585037: Revert the revert. This change was not the cause of the failures, so relanding. (Closed)

Created:
9 years, 1 month ago by Nicolas Zea

Modified:
9 years, 1 month ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), arv (Not doing code reviews), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert the revert. This change was not the cause of the failures, so relanding. Revert 110490 - Revert "[Sync] Add version info to about:sync" This reverts r110456. These tests have been failing on the Mac10.6 Sync builder since this was landed: ManyClientBookmarksSyncTest.Sanity ManyClientPasswordsSyncTest.Sanity ManyClientPreferencesSyncTest.Sanity BUG= TEST= Review URL: http://codereview.chromium.org/8590030 TBR=avi@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110532

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -0 lines)			Patch
M	chrome/browser/resources/sync_internals/about.html	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/all_status.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/all_status.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/internal_api/sync_manager.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/internal_api/sync_manager.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View	4 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages