Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(633)

Issue 8585030: Drop the backbuffer on hidden tabs on GLX image transport. (Closed)

Created:
9 years, 1 month ago by jonathan.backer
Modified:
9 years, 1 month ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, dpranke-watch+content_chromium.org, marcheu
Visibility:
Public.

Description

Drop the backbuffer on hidden tabs on GLX image transport. This saves VRAM usage when multiple accelerated tabs are open by dropping the backbuffer. We do this by resizing the the window. This orphans the GLXPixmap (and texture) that the browser uses to display the front buffer. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110540

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address reviewer comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M content/common/gpu/image_transport_surface_linux.cc View 1 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jonathan.backer
This needs a bit more testing. I tested it on a TOUCHUI build running on ...
9 years, 1 month ago (2011-11-17 14:01:53 UTC) #1
piman
http://codereview.chromium.org/8585030/diff/1/content/common/gpu/image_transport_surface_linux.cc File content/common/gpu/image_transport_surface_linux.cc (right): http://codereview.chromium.org/8585030/diff/1/content/common/gpu/image_transport_surface_linux.cc#newcode469 content/common/gpu/image_transport_surface_linux.cc:469: needs_resize_ = true; Wouldn't you want to set needs_resize_ ...
9 years, 1 month ago (2011-11-17 15:49:33 UTC) #2
jonathan.backer
http://codereview.chromium.org/8585030/diff/1/content/common/gpu/image_transport_surface_linux.cc File content/common/gpu/image_transport_surface_linux.cc (right): http://codereview.chromium.org/8585030/diff/1/content/common/gpu/image_transport_surface_linux.cc#newcode469 content/common/gpu/image_transport_surface_linux.cc:469: needs_resize_ = true; On 2011/11/17 15:49:34, piman wrote: > ...
9 years, 1 month ago (2011-11-17 15:56:09 UTC) #3
piman
LGTM. I suspect your WebKit assert is unrelated, but who knows...
9 years, 1 month ago (2011-11-17 15:57:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/8585030/2002
9 years, 1 month ago (2011-11-17 18:02:16 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 20:05:37 UTC) #6
Change committed as 110540

Powered by Google App Engine
This is Rietveld 408576698