Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8585025: chromeos: Change all clients of UpdateLibrary to use UpdateEngineClient. (Closed)

Created:
9 years, 1 month ago by satorux1
Modified:
9 years, 1 month ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, kkania, robertshield, Paweł Hajdan Jr., stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Change all clients of UpdateLibrary to use UpdateEngineClient. This is part 2 of the UpdateLibrary to UpdateEngineClient migration. UpdateLibrary will be removed in the next patch. BUG=chromium-os:16564 TEST=confirm that the update works as before from chrome://settings/about and OOBE screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111190

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix merge conflicts... #

Patch Set 4 : rebase #

Patch Set 5 : minor fixes #

Total comments: 2

Patch Set 6 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -175 lines) Patch
M chrome/browser/automation/testing_automation_provider_chromeos.cc View 1 2 3 4 5 7 chunks +31 lines, -30 lines 0 comments Download
M chrome/browser/chromeos/dbus/dbus_thread_manager.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/dbus_thread_manager.cc View 4 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/mock_dbus_thread_manager.h View 4 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/mock_dbus_thread_manager.cc View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/update_screen.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen.cc View 1 2 3 4 5 10 chunks +36 lines, -35 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen_browsertest.cc View 1 10 chunks +46 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/upgrade_detector_chromeos.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/upgrade_detector_chromeos.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/policy/device_policy_cache.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 2 3 4 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/about_page_handler.h View 1 2 3 4 5 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/about_page_handler.cc View 1 12 chunks +33 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
satorux1
9 years, 1 month ago (2011-11-17 08:34:47 UTC) #1
stevenjb
lgtm http://codereview.chromium.org/8585025/diff/6002/chrome/browser/ui/webui/options/chromeos/about_page_handler.h File chrome/browser/ui/webui/options/chromeos/about_page_handler.h (right): http://codereview.chromium.org/8585025/diff/6002/chrome/browser/ui/webui/options/chromeos/about_page_handler.h#newcode51 chrome/browser/ui/webui/options/chromeos/about_page_handler.h:51: class UpdateObserver; nit: Forward declaration at start of ...
9 years, 1 month ago (2011-11-21 19:28:05 UTC) #2
satorux1
http://codereview.chromium.org/8585025/diff/6002/chrome/browser/ui/webui/options/chromeos/about_page_handler.h File chrome/browser/ui/webui/options/chromeos/about_page_handler.h (right): http://codereview.chromium.org/8585025/diff/6002/chrome/browser/ui/webui/options/chromeos/about_page_handler.h#newcode51 chrome/browser/ui/webui/options/chromeos/about_page_handler.h:51: class UpdateObserver; On 2011/11/21 19:28:05, Steven Bennetts wrote: > ...
9 years, 1 month ago (2011-11-22 07:33:05 UTC) #3
satorux1
Adding mnissler@ as I needed LGTM from chrome/browser/policy
9 years, 1 month ago (2011-11-22 07:51:24 UTC) #4
Mattias Nissler (ping if slow)
9 years, 1 month ago (2011-11-22 15:29:56 UTC) #5 
chrome/browser/policy LGTM

Powered by Google App Engine
This is Rietveld 408576698