Avoid too many consecutive redraws on about:profiler while loading.

Avoid too many consecutive redraws on about:profiler while loading.

Background: when first opening about:profiler, the browser sends data for each process as it becomes available. The UI responds to this by redrawing all the data. If there are a lot of processes then this can cause many conecutive repaints which slows things down. To avoid this, we now bulk together redraws on a 500ms timer (just for loading, not any user-initiated action).

BUG=100992
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110464

[jar (doing other things), 2011-11-17 07:02:42]

LGTM

I had one question below... but it should not stop a checkin.

http://codereview.chromium.org/8585023/diff/1/chrome/browser/resources/profil...
File chrome/browser/resources/profiler.js (right):

http://codereview.chromium.org/8585023/diff/1/chrome/browser/resources/profil...
chrome/browser/resources/profiler.js:1215: }.bind(this);
curious qusetion: Do you need the .bind(this)?

Wouldn't the method get invoked in the same stack context ,and be able to
pick-up the value of this implicitly?

[eroman, 2011-11-17 07:06:55]

http://codereview.chromium.org/8585023/diff/1/chrome/browser/resources/profil...
File chrome/browser/resources/profiler.js (right):

http://codereview.chromium.org/8585023/diff/1/chrome/browser/resources/profil...
chrome/browser/resources/profiler.js:1215: }.bind(this);
On 2011/11/17 07:02:42, jar wrote:
> curious qusetion: Do you need the .bind(this)?
> 
> Wouldn't the method get invoked in the same stack context ,and be able to
> pick-up the value of this implicitly?

|this| is a very weird beast in javascript. Whereas most variables are lexically
scoped as God intended, |this| is dynamically scoped. Since the function is
invoked later by way of the "setTimeout", the value of the |this| will be bound
to something different when it actually runs.