Enable CSP by default for extensions with manifest_version >= 2.

Enable CSP by default for extensions with manifest_version >= 2.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110531

[abarth-chromium, 2011-11-17 05:19:31]

This patch contains just the basic default policy for manifest_version >= 2. 
Fancier ways of configuring the policy will be in future patches.

[Aaron Boodman, 2011-11-17 07:10:15]

LGTM w/ nit

http://codereview.chromium.org/8585020/diff/25/chrome/common/extensions/exten...
File chrome/common/extensions/extension.cc (right):

http://codereview.chromium.org/8585020/diff/25/chrome/common/extensions/exten...
chrome/common/extensions/extension.cc:1468: manifest_version_ =
manifest_version;
Should we do something about manifest version > 2 ?

[Aaron Boodman, 2011-11-17 07:10:33]

Oh, also, we have extension_manifest_unittests.cc for testing the parsing code.

[abarth-chromium, 2011-11-17 07:14:25]

> Should we do something about manifest version > 2 ?

It seems like the choices are to refuse to load the extension or to load it
anyway.  This patch has us load it anyway, which lets us make forward compatible
changes (like adding a default CSP policy) in the future.  Folks can always use
the minimum_chrome_version attribute if they need to exclude older versions.

However, if you'd like to do something else, I'm happy to change the patch.

[Aaron Boodman, 2011-11-17 07:42:08]

On 2011/11/17 07:14:25, abarth wrote:
> > Should we do something about manifest version > 2 ?
> 
> It seems like the choices are to refuse to load the extension or to load it
> anyway.  This patch has us load it anyway, which lets us make forward
compatible
> changes (like adding a default CSP policy) in the future.  Folks can always
use
> the minimum_chrome_version attribute if they need to exclude older versions.
> 
> However, if you'd like to do something else, I'm happy to change the patch.

Yeah, that makes sense.

[commit-bot: I haz the power, 2011-11-17 08:53:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/abarth@chromium.org/8585020/3003

[commit-bot: I haz the power, 2011-11-17 08:53:49]

Presubmit check for 8585020-3003 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
License must match:
.*? Copyright \(c\) 2011 The Chromium Authors\. All rights reserved\.\n.*? Use
of this source code is governed by a BSD-style license that can be\n.*? found in
the LICENSE file\.\n
Found a bad license header in these files:
  chrome/test/data/extensions/api_test/default_content_security_policy/test.js

Presubmit checks took 1.4s to calculate.