Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: printing/printed_document.cc

Issue 8585017: PrintPreview: Honor the print media page size and margin values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase + fix conflicts Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: printing/printed_document.cc
diff --git a/printing/printed_document.cc b/printing/printed_document.cc
index 77771c442add978351c06be6a83519261710035e..e6c612a1ae0e1217e7cab7ef50f7e1d1dcc2e348 100644
--- a/printing/printed_document.cc
+++ b/printing/printed_document.cc
@@ -78,17 +78,12 @@ void PrintedDocument::SetPage(int page_number,
{
base::AutoLock lock(lock_);
mutable_.pages_[page_number] = page;
+ mutable_.shrink_factor = shrink;
#if defined(OS_POSIX) && !defined(OS_MACOSX)
if (page_number < mutable_.first_page)
mutable_.first_page = page_number;
#endif
-
- if (mutable_.shrink_factor == 0) {
- mutable_.shrink_factor = shrink;
- } else {
- DCHECK_EQ(mutable_.shrink_factor, shrink);
vandebo (ex-Chrome) 2012/01/03 21:55:12 I think this DCHECK is saying that shrink must be
kmadhusu 2012/01/04 16:55:35 Still working on this.
kmadhusu 2012/01/05 01:15:47 Moved shrink_factor to PrintedPage class.
- }
}
DebugDump(*page);
}
« chrome/renderer/print_web_view_helper_win.cc ('K') | « chrome/renderer/print_web_view_helper_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698