Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6024)

Unified Diff: chrome/browser/printing/printing_message_filter.cc

Issue 8585017: PrintPreview: Honor the print media page size and margin values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/printing/printing_message_filter.cc
diff --git a/chrome/browser/printing/printing_message_filter.cc b/chrome/browser/printing/printing_message_filter.cc
index fc5723ec056f0901d76f466a9d152b21f0be2608..ca5d1f66d7bb2883edca3f967ea334798f4cac3b 100644
--- a/chrome/browser/printing/printing_message_filter.cc
+++ b/chrome/browser/printing/printing_message_filter.cc
@@ -47,6 +47,11 @@ void RenderParamsFromPrintSettings(const printing::PrintSettings& settings,
params->printable_size.SetSize(
vandebo (ex-Chrome) 2011/12/03 02:01:45 You're going to rename this in a different CL?
kmadhusu 2011/12/04 01:55:38 Yes. (http://codereview.chromium.org/8784012/)
settings.page_setup_device_units().content_area().width(),
settings.page_setup_device_units().content_area().height());
+ params->printable_area.SetRect(
+ settings.page_setup_device_units().printable_area().x(),
+ settings.page_setup_device_units().printable_area().y(),
+ settings.page_setup_device_units().printable_area().width(),
+ settings.page_setup_device_units().printable_area().height());
params->margin_top = settings.page_setup_device_units().content_area().y();
params->margin_left = settings.page_setup_device_units().content_area().x();
params->dpi = settings.dpi();

Powered by Google App Engine
This is Rietveld 408576698