chrome/browser/printing/printing_message_filter.cc - Issue 8585017: PrintPreview: Honor the print media page size and margin values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/printing_message_filter.cc

Issue 8585017: PrintPreview: Honor the print media page size and margin values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added one more test Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/printing/printing_message_filter.cc

diff --git a/chrome/browser/printing/printing_message_filter.cc b/chrome/browser/printing/printing_message_filter.cc

index ef50b6f38a4b2a62105769be94a6fcdf139ca695..63238e85a3c9c17eb4a4c9cd35f71d3028c79a5c 100644

--- a/chrome/browser/printing/printing_message_filter.cc

+++ b/chrome/browser/printing/printing_message_filter.cc

@@ -47,6 +47,11 @@ void RenderParamsFromPrintSettings(const printing::PrintSettings& settings,

params->content_size.SetSize(

settings.page_setup_device_units().content_area().width(),

settings.page_setup_device_units().content_area().height());

+ params->printable_area.SetRect(

+ settings.page_setup_device_units().printable_area().x(),

+ settings.page_setup_device_units().printable_area().y(),

+ settings.page_setup_device_units().printable_area().width(),

+ settings.page_setup_device_units().printable_area().height());

params->margin_top = settings.page_setup_device_units().content_area().y();

params->margin_left = settings.page_setup_device_units().content_area().x();

params->dpi = settings.dpi();