PrintPreview: Honor the print media page size and margin values.

chrome/renderer/print_web_view_helper.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 108 matching lines @@
 bool PrintMsg_Print_Params_IsEqual(
     const PrintMsg_PrintPages_Params& oldParams,
     const PrintMsg_PrintPages_Params& newParams) {
   return PageLayoutIsEqual(oldParams, newParams) &&
          oldParams.params.max_shrink == newParams.params.max_shrink &&
          oldParams.params.min_shrink == newParams.params.min_shrink &&
          oldParams.params.selection_only == newParams.params.selection_only &&
          oldParams.params.supports_alpha_blend ==
              newParams.params.supports_alpha_blend &&
          oldParams.pages.size() == newParams.pages.size() &&
+         oldParams.params.print_to_pdf == newParams.params.print_to_pdf &&
          oldParams.params.display_header_footer ==
              newParams.params.display_header_footer &&
          oldParams.params.date == newParams.params.date &&
          oldParams.params.title == newParams.params.title &&
          oldParams.params.url == newParams.params.url &&
          std::equal(oldParams.pages.begin(), oldParams.pages.end(),
              newParams.pages.begin());
 }
 
 void CalculatePrintCanvasSize(const PrintMsg_Print_Params& print_params,
                               gfx::Size* result) {
   int dpi = GetDPI(&print_params);
   result->set_width(ConvertUnit(print_params.printable_size.width(), dpi,
                                 print_params.desired_dpi));
 
   result->set_height(ConvertUnit(print_params.printable_size.height(), dpi,
                                  print_params.desired_dpi));
 }
 
 bool PrintingNodeOrPdfFrame(const WebFrame* frame, const WebNode& node) {
   if (!node.isNull())
     return true;
   std::string mime(frame->dataSource()->response().mimeType().utf8());
   return mime == "application/pdf";
 }
 
+bool PrintingFrameHasPageSizeStyle(WebFrame* frame) {
+  if (!frame)
+    return false;
+  return frame->hasCustomPageSizeStyle(0);
+}
+
 printing::MarginType GetMarginsForPdf(WebFrame* frame, const WebNode& node) {
   if (frame->isPrintScalingDisabledForPlugin(node))
     return printing::NO_MARGINS;
   else
     return printing::PRINTABLE_AREA_MARGINS;
 }
 
 // Get the (x, y) coordinate from where printing of the current text should
 // start depending on the horizontal alignment (LEFT, RIGHT, CENTER) and
 // vertical alignment (TOP, BOTTOM).
@@ skipping 268 matching lines @@
       web_frame->setScrollOffset(prev_scroll_offset_);
   }
 }
 
 PrintWebViewHelper::PrintWebViewHelper(content::RenderView* render_view)
     : content::RenderViewObserver(render_view),
       content::RenderViewObserverTracker<PrintWebViewHelper>(render_view),
       print_web_view_(NULL),
       is_preview_enabled_(switches::IsPrintPreviewEnabled()),
       is_print_ready_metafile_sent_(false),
+      ignore_frame_margins_css_(false),
+      fit_to_page_(true),
       user_cancelled_scripted_print_count_(0),
       notify_browser_of_print_failure_(true) {
 }
 
 PrintWebViewHelper::~PrintWebViewHelper() {}
 
 // Prints |frame| which called window.print().
 void PrintWebViewHelper::PrintPage(WebKit::WebFrame* frame) {
   DCHECK(frame);
 
@@ skipping 98 matching lines @@
 void PrintWebViewHelper::OnPrintForSystemDialog() {
   WebFrame* frame = print_preview_context_.frame();
   if (!frame) {
     NOTREACHED();
     return;
   }
 
   Print(frame, print_preview_context_.node());
 }
 
+void PrintWebViewHelper::UpdateFrameMarginsCssInfo(
+    const DictionaryValue& settings) {
+  int margins_type = 0;
+  if (!settings.GetInteger(printing::kSettingMarginsType, &margins_type))
+    margins_type = printing::DEFAULT_MARGINS;
+  ignore_frame_margins_css_ = margins_type != printing::DEFAULT_MARGINS;
+}
+
+bool PrintWebViewHelper::IsPrintToPdfRequested(
+    const DictionaryValue& job_settings) {
+  bool print_to_pdf = false;
+  if (!job_settings.GetBoolean(printing::kSettingPrintToPDF, &print_to_pdf))
+    NOTREACHED();
+  return print_to_pdf;
+}
+
 void PrintWebViewHelper::OnPrintPreview(const DictionaryValue& settings) {
   DCHECK(is_preview_enabled_);
   print_preview_context_.OnPrintPreview();
 
   if (!UpdatePrintSettings(print_preview_context_.frame(),
                            print_preview_context_.node(), settings, false)) {
     if (print_preview_context_.last_error() != PREVIEW_ERROR_BAD_SETTING) {
       Send(new PrintHostMsg_PrintPreviewInvalidPrinterSettings(
           routing_id(), print_pages_params_->params.document_cookie));
       notify_browser_of_print_failure_ = false;  // Already sent.
@@ skipping 40 matching lines @@
   } else {
     if (notify_browser_of_print_failure_)
       LOG(ERROR) << "CreatePreviewDocument failed";
     DidFinishPrinting(FAIL_PREVIEW);
   }
 }
 
 bool PrintWebViewHelper::CreatePreviewDocument() {
   PrintMsg_Print_Params print_params = print_pages_params_->params;
   const std::vector<int>& pages = print_pages_params_->pages;
-  if (!print_preview_context_.CreatePreviewDocument(&print_params, pages))
+  if (!print_preview_context_.CreatePreviewDocument(
+          &print_params, pages, ignore_frame_margins_css_,
+          fit_to_page_)) {
     return false;
+  }
+
+  PageSizeMargins default_page_layout;
+  GetPageSizeAndMarginsInPoints(print_preview_context_.frame(), 0, print_params,
+      ignore_frame_margins_css_, fit_to_page_, NULL, &default_page_layout);
+  if (!old_print_pages_params_.get() ||
+      !PageLayoutIsEqual(*old_print_pages_params_, *print_pages_params_)) {
+    bool has_page_size_style = PrintingFrameHasPageSizeStyle(
+        print_preview_context_.frame());
+    // Margins: Send default page layout to browser process.
+    Send(new PrintHostMsg_DidGetDefaultPageLayout(
+        routing_id(), default_page_layout, has_page_size_style));
+  }
+
   PrintHostMsg_DidGetPreviewPageCount_Params params;
   params.page_count = print_preview_context_.total_page_count();
   params.is_modifiable = print_preview_context_.IsModifiable();
   params.document_cookie = print_pages_params_->params.document_cookie;
   params.preview_request_id = print_pages_params_->params.preview_request_id;
   params.clear_preview_data = print_preview_context_.generate_draft_pages();
   Send(new PrintHostMsg_DidGetPreviewPageCount(routing_id(), params));
   if (CheckForCancel())
     return false;
 
@@ skipping 200 matching lines @@
   return true;
 }
 
 #if defined(OS_MACOSX) || defined(OS_WIN)
 bool PrintWebViewHelper::PrintPages(const PrintMsg_PrintPages_Params& params,
                                     WebFrame* frame,
                                     const WebNode& node) {
   PrintMsg_Print_Params print_params = params.params;
   PrepareFrameAndViewForPrint prep_frame_view(print_params, frame, node);
   UpdatePrintableSizeInPrintParameters(frame, node, &prep_frame_view,
-                                       &print_params);
+                                       &print_params, ignore_frame_margins_css_,
+                                       fit_to_page_);
 
   int page_count = prep_frame_view.GetExpectedPageCount();
   if (!page_count)
     return false;
   Send(new PrintHostMsg_DidGetPrintedPagesCount(routing_id(),
                                                 print_params.document_cookie,
                                                 page_count));
 
   const gfx::Size& canvas_size = prep_frame_view.GetPrintCanvasSize();
   PrintMsg_PrintPage_Params page_params;
@@ skipping 19 matching lines @@
   PrintMsg_PrintPages_Params* params = print_pages_params_.get();
   DCHECK(params != NULL);
   PrintPages(*params, print_web_view_->mainFrame(), WebNode());
 }
 
 // static - Not anonymous so that platform implementations can use it.
 void PrintWebViewHelper::GetPageSizeAndMarginsInPoints(
     WebFrame* frame,
     int page_index,
     const PrintMsg_Print_Params& default_params,
+    bool ignore_frame_margins_css,
+    bool fit_to_page,
+    double* scale_factor,
     PageSizeMargins* page_layout_in_points) {
   int dpi = GetDPI(&default_params);
 
   WebSize page_size_in_pixels(
       ConvertUnit(default_params.page_size.width(),
                   dpi, printing::kPixelsPerInch),
       ConvertUnit(default_params.page_size.height(),
                   dpi, printing::kPixelsPerInch));
   int margin_top_in_pixels = ConvertUnit(
       default_params.margin_top,
       dpi, printing::kPixelsPerInch);
   int margin_right_in_pixels = ConvertUnit(
       default_params.page_size.width() -
       default_params.printable_size.width() - default_params.margin_left,
       dpi, printing::kPixelsPerInch);
   int margin_bottom_in_pixels = ConvertUnit(
       default_params.page_size.height() -
       default_params.printable_size.height() - default_params.margin_top,
       dpi, printing::kPixelsPerInch);
   int margin_left_in_pixels = ConvertUnit(
       default_params.margin_left,
       dpi, printing::kPixelsPerInch);
 
   if (frame) {

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

If I'm reading this correctly, if ignore_frame_margins_css and fit_to_page are
true, then you don't need to call frame->pageSizeAndMarginsInPixels().

So this can be if (frame && !(ignore_frame_margins_css && fit_to_page))

[kmadhusu, 2011/12/02 23:33:19]

Done.

+    int old_margin_top_in_pixels = margin_top_in_pixels;
+    int old_margin_bottom_in_pixels = margin_bottom_in_pixels;
+    int old_margin_left_in_pixels = margin_left_in_pixels;
+    int old_margin_right_in_pixels = margin_right_in_pixels;
+
     frame->pageSizeAndMarginsInPixels(page_index,
                                       page_size_in_pixels,
                                       margin_top_in_pixels,
                                       margin_right_in_pixels,
                                       margin_bottom_in_pixels,
                                       margin_left_in_pixels);
+    if (ignore_frame_margins_css) {
+      margin_top_in_pixels = old_margin_top_in_pixels;
+      margin_bottom_in_pixels = old_margin_bottom_in_pixels;
+      margin_left_in_pixels = old_margin_left_in_pixels;
+      margin_right_in_pixels = old_margin_right_in_pixels;
+    }
   }
 
-  page_layout_in_points->content_width =
+  double new_printable_width =

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

is this printable width, page width, or content width?  I think content width

[kmadhusu, 2011/12/02 23:33:19]

Done.

       ConvertPixelsToPoint(page_size_in_pixels.width -
-                           margin_left_in_pixels -
-                           margin_right_in_pixels);
-  page_layout_in_points->content_height =
+                           margin_left_in_pixels - margin_right_in_pixels);
+  double new_printable_height =
       ConvertPixelsToPoint(page_size_in_pixels.height -
-                           margin_top_in_pixels -
-                           margin_bottom_in_pixels);
+                           margin_top_in_pixels - margin_bottom_in_pixels);
+  double default_printable_width =
+      ConvertUnit(default_params.printable_size.width(),
+                  dpi, printing::kPointsPerInch);
+  double default_printable_height =
+      ConvertUnit(default_params.printable_size.height(),
+                  dpi, printing::kPointsPerInch);
+
+  if (ignore_frame_margins_css && fit_to_page) {
+    new_printable_width = default_printable_width;
+    new_printable_height = default_printable_height;
+  }
 
   // Invalid page size and/or margins. We just use the default setting.
-  if (page_layout_in_points->content_width < 1.0 ||
-      page_layout_in_points->content_height < 1.0) {
+  if (new_printable_width < 1.0 || new_printable_height < 1.0) {
     CHECK(frame != NULL);
-    GetPageSizeAndMarginsInPoints(NULL, page_index, default_params,
-                                  page_layout_in_points);
+    GetPageSizeAndMarginsInPoints(NULL, page_index, default_params, false,
+                                  false, NULL, page_layout_in_points);
     return;
   }
+  double margin_top_in_points =
+      ConvertPixelsToPointDouble(margin_top_in_pixels);
+  double margin_right_in_points =
+      ConvertPixelsToPointDouble(margin_right_in_pixels);
+  double margin_left_in_points =
+      ConvertPixelsToPointDouble(margin_left_in_pixels);
+  double margin_bottom_in_points =
+      ConvertPixelsToPointDouble(margin_bottom_in_pixels);
+  double content_width = new_printable_width;
+  double content_height = new_printable_height;
 
-    page_layout_in_points->margin_top =
-        ConvertPixelsToPointDouble(margin_top_in_pixels);
-    page_layout_in_points->margin_right =
-        ConvertPixelsToPointDouble(margin_right_in_pixels);
-    page_layout_in_points->margin_bottom =
-        ConvertPixelsToPointDouble(margin_bottom_in_pixels);
-    page_layout_in_points->margin_left =
-        ConvertPixelsToPointDouble(margin_left_in_pixels);
+  if (fit_to_page && (default_printable_height != new_printable_height ||
+      default_printable_width != new_printable_width)) {
+    double default_page_size_height =
+        ConvertUnit(default_params.page_size.height(), dpi,
+                    printing::kPointsPerInch);
+    double default_page_size_width =
+        ConvertUnit(default_params.page_size.width(), dpi,
+                    printing::kPointsPerInch);
+    if (default_printable_width < new_printable_width ||
+        default_printable_height < new_printable_height) {
+      double ratio_width = default_printable_width / new_printable_width;

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

I think we want to scale the CSS page box into the printable area / minimum
margins on the physical page.

[kmadhusu, 2011/12/02 23:33:19]

Done.

[kmadhusu, 2011/12/02 23:33:19]

Done.

+      double ratio_height = default_printable_height / new_printable_height;
+      double factor = ratio_width < ratio_height ? ratio_width : ratio_height;
+      if (scale_factor)
+        *scale_factor = factor;
+
+      content_width *= factor;
+      content_height *= factor;
+      margin_top_in_points =  default_page_size_height/2 - content_height/2;

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

(default_page_size_height - content_height) / 2;

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

If we scale the CSS page box into the printable area, then the top margin should
be the printable area top margin plus the css top margin times the scale factor.

[kmadhusu, 2011/12/02 23:33:19]

Done.

+      margin_left_in_points = default_page_size_width/2 - content_width/2;
+      margin_right_in_points = default_page_size_width -
+                               margin_left_in_points - content_width;
+      margin_bottom_in_points = default_page_size_height -
+                                margin_top_in_points - content_height;
+      } else {
+        int margin_top_bottom = margin_top_in_points + margin_bottom_in_points;

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

This doesn't seem to work out.  The formula we worked out for bottom (which
generalized to all of the margins) is:

(physical height - css height * scale factor)/2 + (css bottom margin * scale
factor)

[kmadhusu, 2011/12/02 23:33:19]

This is the formula for scaling. I have also updated the centering formula.

+        int margin_left_right = margin_left_in_points + margin_right_in_points;
+        double ratio_y = 1.0f, ratio_x = 1.0f;
+        if (margin_top_bottom > 0) {
+          ratio_y = (default_page_size_height - new_printable_height) /
+                    margin_top_bottom;
+        }
+        if (margin_left_right > 0) {
+          ratio_x = (default_page_size_width - new_printable_width) /
+                      margin_left_right;
+        }
+        margin_top_in_points *= ratio_y;
+        margin_left_in_points *= ratio_x;
+        margin_right_in_points *= ratio_x;
+        margin_bottom_in_points *= ratio_y;
+    }
+  }
+  page_layout_in_points->content_width = content_width;
+  page_layout_in_points->content_height = content_height;
+  page_layout_in_points->margin_top = margin_top_in_points;
+  page_layout_in_points->margin_right = margin_right_in_points;
+  page_layout_in_points->margin_bottom = margin_bottom_in_points;
+  page_layout_in_points->margin_left = margin_left_in_points;
 }
 
 // static - Not anonymous so that platform implementations can use it.
 void PrintWebViewHelper::UpdatePrintableSizeInPrintParameters(
     WebFrame* frame,
     const WebNode& node,
     PrepareFrameAndViewForPrint* prepare,
-    PrintMsg_Print_Params* params) {
+    PrintMsg_Print_Params* params,

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

pass by value, since we want to change it in the body anyway.

[kmadhusu, 2011/12/02 23:33:19]

Done.

+    bool ignore_frame_margins_css,
+    bool fit_to_page) {
   if (PrintingNodeOrPdfFrame(frame, node))
     return;
   PageSizeMargins page_layout_in_points;
-  PrintWebViewHelper::GetPageSizeAndMarginsInPoints(frame, 0, *params,
-                                                    &page_layout_in_points);
+  PrintMsg_Print_Params current_params = *params;
+  PrintWebViewHelper::GetPageSizeAndMarginsInPoints(frame, 0, current_params,
+      ignore_frame_margins_css, false, NULL, &page_layout_in_points);
   int dpi = GetDPI(params);
-  params->printable_size = gfx::Size(
+  current_params.printable_size = gfx::Size(
       static_cast<int>(ConvertUnitDouble(
           page_layout_in_points.content_width,
           printing::kPointsPerInch, dpi)),
       static_cast<int>(ConvertUnitDouble(
           page_layout_in_points.content_height,
           printing::kPointsPerInch, dpi)));
-
   double page_width_in_points =
       page_layout_in_points.content_width +
       page_layout_in_points.margin_left +
       page_layout_in_points.margin_right;
   double page_height_in_points =
       page_layout_in_points.content_height +
       page_layout_in_points.margin_top +
       page_layout_in_points.margin_bottom;
 
-  params->page_size = gfx::Size(
-      static_cast<int>(ConvertUnitDouble(
+  current_params.page_size = gfx::Size(
+     static_cast<int>(ConvertUnitDouble(
           page_width_in_points, printing::kPointsPerInch, dpi)),
       static_cast<int>(ConvertUnitDouble(
           page_height_in_points, printing::kPointsPerInch, dpi)));
-
-  params->margin_top = static_cast<int>(ConvertUnitDouble(
+  current_params.margin_top =
+  static_cast<int>(ConvertUnitDouble(
       page_layout_in_points.margin_top, printing::kPointsPerInch, dpi));
-  params->margin_left = static_cast<int>(ConvertUnitDouble(
+  current_params.margin_left = static_cast<int>(ConvertUnitDouble(
       page_layout_in_points.margin_left, printing::kPointsPerInch, dpi));
-
-  prepare->UpdatePrintParams(*params);
+  prepare->UpdatePrintParams(current_params);
 }
 
 bool PrintWebViewHelper::InitPrintSettings(WebKit::WebFrame* frame,
                                            const WebKit::WebNode& node) {
   DCHECK(frame);
   PrintMsg_PrintPages_Params settings;
 
   Send(new PrintHostMsg_GetDefaultPrintSettings(routing_id(),
                                                 &settings.params));
   // Check if the printer returned any settings, if the settings is empty, we
@@ skipping 23 matching lines @@
 bool PrintWebViewHelper::InitPrintSettingsAndPrepareFrame(
     WebKit::WebFrame* frame, const WebKit::WebNode& node,
     scoped_ptr<PrepareFrameAndViewForPrint>* prepare) {
   if (!InitPrintSettings(frame, node))
     return false;
 
   DCHECK(!prepare->get());
   prepare->reset(new PrepareFrameAndViewForPrint(print_pages_params_->params,
                                                  frame, node));
   UpdatePrintableSizeInPrintParameters(frame, node, prepare->get(),
-                                       &print_pages_params_->params);
+                                       &print_pages_params_->params,
+                                       ignore_frame_margins_css_,
+                                       fit_to_page_);
   Send(new PrintHostMsg_DidGetDocumentCookie(
         routing_id(), print_pages_params_->params.document_cookie));
   return true;
 }
 
 bool PrintWebViewHelper::UpdatePrintSettings(
     WebKit::WebFrame* frame, const WebKit::WebNode& node,
     const DictionaryValue& passed_job_settings, bool print_for_preview) {
   DCHECK(is_preview_enabled_);
   const DictionaryValue* job_settings = &passed_job_settings;
@@ skipping 33 matching lines @@
     bool get_margins_from_pdf = false;
 #endif
 
     printing::MarginType margin_type = printing::NO_MARGINS;
     if (get_margins_from_pdf)
       margin_type = GetMarginsForPdf(frame, node);
     modified_job_settings.SetInteger(printing::kSettingMarginsType,
                                      margin_type);
     job_settings = &modified_job_settings;
   }
+  UpdateFrameMarginsCssInfo(*job_settings);

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

You can put both of these lines in a !print_for_preview block and remove it from
the assignment.

[kmadhusu, 2011/12/02 23:33:19]

Done.

+  fit_to_page_ = !print_for_preview && source_is_html &&
+                 !IsPrintToPdfRequested(*job_settings);
 
   // Send the cookie so that UpdatePrintSettings can reuse PrinterQuery when
   // possible.
   int cookie = print_pages_params_.get() ?
       print_pages_params_->params.document_cookie : 0;
   PrintMsg_PrintPages_Params settings;
   Send(new PrintHostMsg_UpdatePrintSettings(routing_id(),
       cookie, *job_settings, &settings));
   print_pages_params_.reset(new PrintMsg_PrintPages_Params(settings));
 
@@ skipping 27 matching lines @@
                                  &(settings.params.preview_ui_addr)) ||
         !job_settings->GetInteger(printing::kPreviewRequestID,
                                   &(settings.params.preview_request_id)) ||
         !job_settings->GetBoolean(printing::kIsFirstRequest,
                                   &(settings.params.is_first_request))) {
       NOTREACHED();
       print_preview_context_.set_error(PREVIEW_ERROR_BAD_SETTING);
       return false;
     }
 
-    // Margins: Send default page layout to browser process.
-    PageSizeMargins default_page_layout;
-    GetPageSizeAndMarginsInPoints(NULL, -1, settings.params,
-                                  &default_page_layout);
-    if (!old_print_pages_params_.get() ||
-        !PageLayoutIsEqual(*old_print_pages_params_, settings)) {
-      Send(new PrintHostMsg_DidGetDefaultPageLayout(routing_id(),
-                                                    default_page_layout));
-    }
+    settings.params.print_to_pdf = IsPrintToPdfRequested(*job_settings);

[vandebo (ex-Chrome), 2011/12/02 01:28:19]

I think this can go inside the !print_for_preview block

[kmadhusu, 2011/12/02 23:33:19]

It is already within that block.

 
     // Header/Footer: Set |header_footer_info_|.
     if (settings.params.display_header_footer) {
       header_footer_info_.reset(new DictionaryValue());
       header_footer_info_->SetString(printing::kSettingHeaderFooterDate,
                                      settings.params.date);
       header_footer_info_->SetString(printing::kSettingHeaderFooterURL,
                                      settings.params.url);
       header_footer_info_->SetString(printing::kSettingHeaderFooterTitle,
                                      settings.params.title);
@@ skipping 217 matching lines @@
   node_ = web_node;
 }
 
 void PrintWebViewHelper::PrintPreviewContext::OnPrintPreview() {
   DCHECK_EQ(INITIALIZED, state_);
   ClearContext();
 }
 
 bool PrintWebViewHelper::PrintPreviewContext::CreatePreviewDocument(
     PrintMsg_Print_Params* print_params,
-    const std::vector<int>& pages) {
+    const std::vector<int>& pages,
+    bool ignore_frame_margins_css,
+    bool fit_to_page) {
   DCHECK_EQ(INITIALIZED, state_);
   state_ = RENDERING;
 
   metafile_.reset(new printing::PreviewMetafile);
   if (!metafile_->Init()) {
     set_error(PREVIEW_ERROR_METAFILE_INIT_FAILED);
     LOG(ERROR) << "PreviewMetafile Init failed";
     return false;
   }
 
   // Need to make sure old object gets destroyed first.
   prep_frame_view_.reset(new PrepareFrameAndViewForPrint(*print_params, frame(),
                                                          node()));
   UpdatePrintableSizeInPrintParameters(frame_, node_,
-                                       prep_frame_view_.get(), print_params);
+                                       prep_frame_view_.get(), print_params,
+                                       ignore_frame_margins_css,
+                                       fit_to_page);
 
   print_params_.reset(new PrintMsg_Print_Params(*print_params));
 
   total_page_count_ = prep_frame_view_->GetExpectedPageCount();
   if (total_page_count_ == 0) {
     LOG(ERROR) << "CreatePreviewDocument got 0 page count";
     set_error(PREVIEW_ERROR_ZERO_PAGES);
     return false;
   }
 
@@ skipping 155 matching lines @@
   DCHECK(IsRendering());
   return prep_frame_view_->GetPrintCanvasSize();
 }
 
 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
   prep_frame_view_.reset();
   metafile_.reset();
   pages_to_render_.clear();
   error_ = PREVIEW_ERROR_NONE;
 }