Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1815)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 8585016: Don't use process isolation for bookmark apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix bug with old_url. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 3f77711f17aa97c251d970882c1fcb24e9bfa3ab..8a725e5087a331ebc7ae1db53d14716ba1a65a18 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -2187,7 +2187,7 @@ const Extension* ExtensionService::GetDisabledExtensionByWebExtent(
bool ExtensionService::ExtensionBindingsAllowed(const GURL& url) {
// Allow bindings for all packaged extensions.
// Note that GetExtensionByURL may return an Extension for hosted apps
- // if the URL came from GetEffectiveURL.
+ // (excluding bookmark apps) if the URL came from GetEffectiveURL.
Aaron Boodman 2011/11/18 18:19:52 I don't think the last part of this comment is nec
Charlie Reis 2011/11/18 19:45:42 I think it's useful to have that comment, since it
const Extension* extension = GetExtensionByURL(url);
if (extension && extension->GetType() != Extension::TYPE_HOSTED_APP)
return true;

Powered by Google App Engine
This is Rietveld 408576698