Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Unified Diff: chrome/common/extensions/extension_set.cc

Issue 8585016: Don't use process isolation for bookmark apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_set.cc
diff --git a/chrome/common/extensions/extension_set.cc b/chrome/common/extensions/extension_set.cc
index 105420bc9605d368c96f8fae11fa6f772e158342..9a716855b0632d7447798d994027cbce4c5a962d 100644
--- a/chrome/common/extensions/extension_set.cc
+++ b/chrome/common/extensions/extension_set.cc
@@ -46,8 +46,12 @@ const Extension* ExtensionSet::GetByURL(const GURL& url) const {
ExtensionMap::const_iterator i = extensions_.begin();
for (; i != extensions_.end(); ++i) {
- if (i->second->web_extent().MatchesURL(url))
+ // Exclude bookmark apps so that they do not affect the process model.
+ // TODO(creis): Where is the right place to do this exclusion?
+ if (i->second->web_extent().MatchesURL(url) &&
+ !i->second->from_bookmark()) {
return i->second.get();
+ }
}
return NULL;

Powered by Google App Engine
This is Rietveld 408576698