Implement ui_controls for aura

ui/base/x/events_x.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/events.h"
 
 #include <X11/Xlib.h>
 #include <X11/extensions/XInput2.h>
 
 #include "base/logging.h"
 #include "ui/base/keycodes/keyboard_code_conversion_x.h"
 #include "ui/base/touch/touch_factory.h"
 #include "ui/gfx/point.h"
 
+#if !defined(TOOLKIT_USES_GTK)
+#include "base/message_pump_x.h"
+#endif
+
 namespace {
 
 // Scroll amount for each wheelscroll event. 53 is also the value used for GTK+.
 static const int kWheelScrollAmount = 53;
 
 static const int kMinWheelButton = 4;
 #if defined(OS_CHROMEOS)
 // Chrome OS also uses buttons 8 and 9 for scrolling.
 static const int kMaxWheelButton = 9;
 #else
@@ skipping 339 matching lines @@
   unsigned int deviceid =
       static_cast<XIDeviceEvent*>(native_event->xcookie.data)->sourceid;
   // Force is normalized to fall into [0, 1]
   if (!ui::TouchFactory::GetInstance()->NormalizeTouchParam(
       deviceid, ui::TouchFactory::TP_PRESSURE, &force))
     force = 0.0;
   return force;
 }
 
 base::NativeEvent CreateNoopEvent() {
-  static XEvent* noop = new XEvent();
-  noop->xclient.type = ClientMessage;
-  noop->xclient.display = NULL;
-  noop->xclient.window = None;
-  noop->xclient.message_type = 0;
-  noop->xclient.format = 0;
+  static XEvent* noop = NULL;
+  if (!noop) {
+    noop = new XEvent();

[Daniel Erat, 2011/11/22 01:46:14]

i don't think there's any non-default constructor here; this is a C struct with
POD members

[oshima, 2011/11/22 03:02:09]

C++ supposed to be able to initialize POD types in struct when it's allocated
with (), BUT I just realized that XEvent is union, so this doesn't work (not
sure HOW this works on union). my bad. changed to use memset.

+    noop->xclient.type = ClientMessage;
+    noop->xclient.window = None;

[Daniel Erat, 2011/11/22 01:46:14]

None == 0

[oshima, 2011/11/22 03:02:09]

Hmm, it's implementation details and I think we shouldn't rely on that.

+    noop->xclient.format = 8;
+    DCHECK(!noop->xclient.display);
+  }
+  // TODO(oshima): Remove ifdef once gtk is removed from views.
+#if defined(TOOLKIT_USES_GTK)
+  NOTREACHED();
+#else
+  // Make sure we use atom from current xdisplay, which may
+  // change during the test.
+  noop->xclient.message_type = XInternAtom(
+      base::MessagePumpX::GetDefaultXDisplay(),
+      "noop", False);
+#endif
   return noop;
 }
 
 }  // namespace ui